From: Sabrina Dubroca <sd@queasysnail.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Chuck Lever <cel@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Shuah Khan <shuah@kernel.org>, Jeff Layton <jlayton@kernel.org>,
NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
netdev@vger.kernel.org, kernel-tls-handshake@lists.linux.dev,
linux-kselftest@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/6] net: Introduce read_sock_rectype proto_ops for control record delivery
Date: Thu, 30 Jul 2026 16:16:33 +0200 [thread overview]
Message-ID: <amtcwSO24GGq_qd0@krikkit> (raw)
In-Reply-To: <20260729163142.4f41484f@kernel.org>
2026-07-29, 16:31:42 -0700, Jakub Kicinski wrote:
> On Tue, 28 Jul 2026 22:51:30 -0400 Chuck Lever wrote:
> > >> It’s not about LOC. It’s about not cluttering the normal I/O
> > >> path with a lot of exception processing to handle TLS Alert
> > >> records. The CMSG API is very difficult to use and leaks the
> > >> alert messages into I/O buffers (which for in-kernel consumers
> > >> are page cache pages). It’s piss-poor API design.
> > >
> > > I'm not arguing that it's amazing. Doesn't mean we will YOLO
> > > a special proto callback for every protocol stacking :/
> >
> > No-one is asking you to roll over. Review means you get to steer
> > us in the right direction, and I promise to do the leg work. Terse
> > rejection doesn’t move the discussion forward. It stops it cold.
>
> With LLMs tho, the entire human effort is in finding the right design,
> rather than the code. So asking maintainers to hand hold everyone thru
> their features is unrealistic.
>
> Off the top of my head I think a setsockopt which pre-seeds the content
> type so that the read returns an errno if the queued content type is
> different could be a simple fix. You'd configure that on your sockets
> to DATA and once you see a EWHATEVER you'd assume that some special
> record arrived and the socket has to be handed back over to the TLS
> control path. This is literally the first thing that comes to mind,
> IDK how ugly it will look in reality so no promises.
But then you're back to "read_sock stopped, caller has to take some
special action to handle the next bit of payload". It's not better
than "read_sock, and do a recvmsg when read_sock says it's not DATA".
--
Sabrina
next prev parent reply other threads:[~2026-07-30 14:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 14:27 [PATCH net-next v2 0/6] Deliver TLS control records to kernel read_sock consumers Chuck Lever
2026-07-20 14:27 ` [PATCH net-next v2 1/6] net/tls: Bound consecutive no-data records in tls_sw_read_sock() Chuck Lever
2026-07-23 7:11 ` Hannes Reinecke
2026-07-23 13:24 ` Chuck Lever
2026-07-23 14:23 ` Sabrina Dubroca
2026-07-23 14:29 ` Chuck Lever
2026-07-23 22:05 ` Sabrina Dubroca
2026-07-29 1:47 ` Jakub Kicinski
2026-07-29 3:17 ` Chuck Lever
2026-07-20 14:27 ` [PATCH net-next v2 2/6] net: Introduce read_sock_rectype proto_ops for control record delivery Chuck Lever
2026-07-23 7:14 ` Hannes Reinecke
2026-07-29 1:51 ` Jakub Kicinski
2026-07-29 1:57 ` Chuck Lever
2026-07-29 2:30 ` Jakub Kicinski
2026-07-29 2:51 ` Chuck Lever
2026-07-29 12:23 ` Sabrina Dubroca
2026-07-29 13:13 ` Chuck Lever
2026-07-29 23:31 ` Jakub Kicinski
2026-07-30 14:16 ` Sabrina Dubroca [this message]
2026-07-20 14:27 ` [PATCH net-next v2 3/6] tls: Implement read_sock_rectype for kTLS software path Chuck Lever
2026-07-23 7:14 ` Hannes Reinecke
2026-07-20 14:27 ` [PATCH net-next v2 4/6] selftests/tls: Add tests for data/control record interleaving Chuck Lever
2026-07-20 14:27 ` [PATCH net-next v2 5/6] SUNRPC: Use read_sock_rectype for svcsock TCP receives Chuck Lever
2026-07-20 14:28 ` [PATCH net-next v2 6/6] SUNRPC: Remove sock_recvmsg path from " Chuck Lever
2026-07-23 7:19 ` [PATCH net-next v2 0/6] Deliver TLS control records to kernel read_sock consumers Hannes Reinecke
2026-07-29 1:43 ` Jakub Kicinski
2026-07-29 1:46 ` Chuck Lever
2026-07-29 1:55 ` Jakub Kicinski
2026-07-29 2:16 ` Chuck Lever
2026-07-29 2:24 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amtcwSO24GGq_qd0@krikkit \
--to=sd@queasysnail.net \
--cc=Dai.Ngo@oracle.com \
--cc=cel@kernel.org \
--cc=horms@kernel.org \
--cc=jlayton@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kernel-tls-handshake@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=netdev@vger.kernel.org \
--cc=okorniev@redhat.com \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox