From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Jaeyeon Lee <jaeyeon.lee.dev@gmail.com>
Cc: akpm@linux-foundation.org, shuah@kernel.org, david@kernel.org,
liam@infradead.org, vbabka@kernel.org, rppt@kernel.org,
surenb@google.com, mhocko@suse.com, ziy@nvidia.com,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/mm: skip khugepaged file tests if mkfs.xfs is unavailable
Date: Fri, 11 Sep 2026 14:01:55 +0100 [thread overview]
Message-ID: <aqP7gW98GIiYgL1z@gremlin> (raw)
In-Reply-To: <20260911124517.63714-1-jaeyeon.lee.dev@gmail.com>
On Fri, Sep 11, 2026 at 02:45:17PM +0200, Jaeyeon Lee wrote:
> The XFS setup for ./khugepaged all:file checks that the kernel supports
> XFS but not that mkfs.xfs is installed. When CONFIG_XFS_FS=y and
> xfsprogs is missing, mkfs.xfs and mount both fail, but
> SPLIT_HUGE_PAGE_TEST_XFS_PATH is assigned from mktemp -d and stays set.
> The test then runs against plain tmpfs and six subtests fail.
>
> The script already has a skip path for this test, but it never runs
> because the path variable is always set. Check that mkfs.xfs exists
> before attempting the XFS setup.
>
> Assisted-by: claude.ai:claude-opus-5
Convention is now:
Assisted-by: LLM
See https://docs.kernel.org/process/coding-assistants.html
> Signed-off-by: Jaeyeon Lee <jaeyeon.lee.dev@gmail.com>
This seems sensible, so with the tag fixed:
Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> ---
> tools/testing/selftests/mm/run_vmtests.sh | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
> index d09f9f6a384e..6315b67b6733 100755
> --- a/tools/testing/selftests/mm/run_vmtests.sh
> +++ b/tools/testing/selftests/mm/run_vmtests.sh
> @@ -415,7 +415,8 @@ CATEGORY="thp" run_test ./khugepaged -c 4 mthp_khugepaged:anon
> # Try to create XFS if not provided
> if [ -z "${SPLIT_HUGE_PAGE_TEST_XFS_PATH}" ]; then
> if test_selected "thp"; then
> - if grep xfs /proc/filesystems &>/dev/null; then
> + if grep xfs /proc/filesystems &>/dev/null &&
> + command -v mkfs.xfs &>/dev/null; then
> XFS_IMG=$(mktemp /tmp/xfs_img_XXXXXX)
> SPLIT_HUGE_PAGE_TEST_XFS_PATH=$(mktemp -d /tmp/xfs_dir_XXXXXX)
> truncate -s 314572800 ${XFS_IMG}
> --
> 2.43.0
>
--
Cheers, Lorenzo
next prev parent reply other threads:[~2026-09-11 13:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 12:45 [PATCH] selftests/mm: skip khugepaged file tests if mkfs.xfs is unavailable Jaeyeon Lee
2026-09-11 13:01 ` Lorenzo Stoakes (ARM) [this message]
2026-09-11 23:56 ` Andrew Morton
2026-09-12 0:09 ` Zi Yan
2026-09-12 0:06 ` Zi Yan
2026-09-12 13:29 ` Jaeyeon Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqP7gW98GIiYgL1z@gremlin \
--to=ljs@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=jaeyeon.lee.dev@gmail.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox