* [PATCH] selftests/mm: skip khugepaged file tests if mkfs.xfs is unavailable
@ 2026-09-11 12:45 Jaeyeon Lee
2026-09-11 13:01 ` Lorenzo Stoakes (ARM)
2026-09-12 0:06 ` Zi Yan
0 siblings, 2 replies; 6+ messages in thread
From: Jaeyeon Lee @ 2026-09-11 12:45 UTC (permalink / raw)
To: akpm, shuah
Cc: david, ljs, liam, vbabka, rppt, surenb, mhocko, ziy, linux-mm,
linux-kselftest, linux-kernel, Jaeyeon Lee
The XFS setup for ./khugepaged all:file checks that the kernel supports
XFS but not that mkfs.xfs is installed. When CONFIG_XFS_FS=y and
xfsprogs is missing, mkfs.xfs and mount both fail, but
SPLIT_HUGE_PAGE_TEST_XFS_PATH is assigned from mktemp -d and stays set.
The test then runs against plain tmpfs and six subtests fail.
The script already has a skip path for this test, but it never runs
because the path variable is always set. Check that mkfs.xfs exists
before attempting the XFS setup.
Assisted-by: claude.ai:claude-opus-5
Signed-off-by: Jaeyeon Lee <jaeyeon.lee.dev@gmail.com>
---
tools/testing/selftests/mm/run_vmtests.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
index d09f9f6a384e..6315b67b6733 100755
--- a/tools/testing/selftests/mm/run_vmtests.sh
+++ b/tools/testing/selftests/mm/run_vmtests.sh
@@ -415,7 +415,8 @@ CATEGORY="thp" run_test ./khugepaged -c 4 mthp_khugepaged:anon
# Try to create XFS if not provided
if [ -z "${SPLIT_HUGE_PAGE_TEST_XFS_PATH}" ]; then
if test_selected "thp"; then
- if grep xfs /proc/filesystems &>/dev/null; then
+ if grep xfs /proc/filesystems &>/dev/null &&
+ command -v mkfs.xfs &>/dev/null; then
XFS_IMG=$(mktemp /tmp/xfs_img_XXXXXX)
SPLIT_HUGE_PAGE_TEST_XFS_PATH=$(mktemp -d /tmp/xfs_dir_XXXXXX)
truncate -s 314572800 ${XFS_IMG}
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] selftests/mm: skip khugepaged file tests if mkfs.xfs is unavailable
2026-09-11 12:45 [PATCH] selftests/mm: skip khugepaged file tests if mkfs.xfs is unavailable Jaeyeon Lee
@ 2026-09-11 13:01 ` Lorenzo Stoakes (ARM)
2026-09-11 23:56 ` Andrew Morton
2026-09-12 0:06 ` Zi Yan
1 sibling, 1 reply; 6+ messages in thread
From: Lorenzo Stoakes (ARM) @ 2026-09-11 13:01 UTC (permalink / raw)
To: Jaeyeon Lee
Cc: akpm, shuah, david, liam, vbabka, rppt, surenb, mhocko, ziy,
linux-mm, linux-kselftest, linux-kernel
On Fri, Sep 11, 2026 at 02:45:17PM +0200, Jaeyeon Lee wrote:
> The XFS setup for ./khugepaged all:file checks that the kernel supports
> XFS but not that mkfs.xfs is installed. When CONFIG_XFS_FS=y and
> xfsprogs is missing, mkfs.xfs and mount both fail, but
> SPLIT_HUGE_PAGE_TEST_XFS_PATH is assigned from mktemp -d and stays set.
> The test then runs against plain tmpfs and six subtests fail.
>
> The script already has a skip path for this test, but it never runs
> because the path variable is always set. Check that mkfs.xfs exists
> before attempting the XFS setup.
>
> Assisted-by: claude.ai:claude-opus-5
Convention is now:
Assisted-by: LLM
See https://docs.kernel.org/process/coding-assistants.html
> Signed-off-by: Jaeyeon Lee <jaeyeon.lee.dev@gmail.com>
This seems sensible, so with the tag fixed:
Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> ---
> tools/testing/selftests/mm/run_vmtests.sh | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
> index d09f9f6a384e..6315b67b6733 100755
> --- a/tools/testing/selftests/mm/run_vmtests.sh
> +++ b/tools/testing/selftests/mm/run_vmtests.sh
> @@ -415,7 +415,8 @@ CATEGORY="thp" run_test ./khugepaged -c 4 mthp_khugepaged:anon
> # Try to create XFS if not provided
> if [ -z "${SPLIT_HUGE_PAGE_TEST_XFS_PATH}" ]; then
> if test_selected "thp"; then
> - if grep xfs /proc/filesystems &>/dev/null; then
> + if grep xfs /proc/filesystems &>/dev/null &&
> + command -v mkfs.xfs &>/dev/null; then
> XFS_IMG=$(mktemp /tmp/xfs_img_XXXXXX)
> SPLIT_HUGE_PAGE_TEST_XFS_PATH=$(mktemp -d /tmp/xfs_dir_XXXXXX)
> truncate -s 314572800 ${XFS_IMG}
> --
> 2.43.0
>
--
Cheers, Lorenzo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] selftests/mm: skip khugepaged file tests if mkfs.xfs is unavailable
2026-09-11 13:01 ` Lorenzo Stoakes (ARM)
@ 2026-09-11 23:56 ` Andrew Morton
2026-09-12 0:09 ` Zi Yan
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2026-09-11 23:56 UTC (permalink / raw)
To: Lorenzo Stoakes (ARM)
Cc: Jaeyeon Lee, shuah, david, liam, vbabka, rppt, surenb, mhocko,
ziy, linux-mm, linux-kselftest, linux-kernel
On Fri, 11 Sep 2026 14:01:55 +0100 "Lorenzo Stoakes (ARM)" <ljs@kernel.org> wrote:
> > Assisted-by: claude.ai:claude-opus-5
>
> Convention is now:
>
> Assisted-by: LLM
>
> See https://docs.kernel.org/process/coding-assistants.html
Yeah. That's so lame. I like seeing what people are using - it's
interesting.
Also tautological. What else will we ever place after
"Assisted-by: "? Dr Watson?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] selftests/mm: skip khugepaged file tests if mkfs.xfs is unavailable
2026-09-11 12:45 [PATCH] selftests/mm: skip khugepaged file tests if mkfs.xfs is unavailable Jaeyeon Lee
2026-09-11 13:01 ` Lorenzo Stoakes (ARM)
@ 2026-09-12 0:06 ` Zi Yan
2026-09-12 13:29 ` Jaeyeon Lee
1 sibling, 1 reply; 6+ messages in thread
From: Zi Yan @ 2026-09-12 0:06 UTC (permalink / raw)
To: Jaeyeon Lee
Cc: akpm, shuah, david, ljs, liam, vbabka, rppt, surenb, mhocko,
linux-mm, linux-kselftest, linux-kernel
On 11 Sep 2026, at 8:45, Jaeyeon Lee wrote:
> The XFS setup for ./khugepaged all:file checks that the kernel supports
> XFS but not that mkfs.xfs is installed. When CONFIG_XFS_FS=y and
> xfsprogs is missing, mkfs.xfs and mount both fail, but
> SPLIT_HUGE_PAGE_TEST_XFS_PATH is assigned from mktemp -d and stays set.
> The test then runs against plain tmpfs and six subtests fail.
>
> The script already has a skip path for this test, but it never runs
> because the path variable is always set. Check that mkfs.xfs exists
> before attempting the XFS setup.
>
> Assisted-by: claude.ai:claude-opus-5
> Signed-off-by: Jaeyeon Lee <jaeyeon.lee.dev@gmail.com>
> ---
> tools/testing/selftests/mm/run_vmtests.sh | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
> index d09f9f6a384e..6315b67b6733 100755
> --- a/tools/testing/selftests/mm/run_vmtests.sh
> +++ b/tools/testing/selftests/mm/run_vmtests.sh
> @@ -415,7 +415,8 @@ CATEGORY="thp" run_test ./khugepaged -c 4 mthp_khugepaged:anon
> # Try to create XFS if not provided
> if [ -z "${SPLIT_HUGE_PAGE_TEST_XFS_PATH}" ]; then
> if test_selected "thp"; then
> - if grep xfs /proc/filesystems &>/dev/null; then
> + if grep xfs /proc/filesystems &>/dev/null &&
> + command -v mkfs.xfs &>/dev/null; then
> XFS_IMG=$(mktemp /tmp/xfs_img_XXXXXX)
> SPLIT_HUGE_PAGE_TEST_XFS_PATH=$(mktemp -d /tmp/xfs_dir_XXXXXX)
> truncate -s 314572800 ${XFS_IMG}
>
This might be more robust, since it can detect mkfs.xfs and mount failures.
if grep xfs /proc/filesystems &>/dev/null; then
XFS_IMG=$(mktemp /tmp/xfs_img_XXXXXX)
XFS_DIR=$(mktemp -d /tmp/xfs_dir_XXXXXX)
truncate -s 314572800 ${XFS_IMG}
if mkfs.xfs -q ${XFS_IMG} && mount -t xfs -o loop ${XFS_IMG} ${XFS_DIR}; then
SPLIT_HUGE_PAGE_TEST_XFS_PATH=${XFS_DIR}
MOUNTED_XFS=1
else
rmdir ${XFS_DIR}
rm -f ${XFS_IMG}
fi
fi
Best Regards,
Yan, Zi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] selftests/mm: skip khugepaged file tests if mkfs.xfs is unavailable
2026-09-11 23:56 ` Andrew Morton
@ 2026-09-12 0:09 ` Zi Yan
0 siblings, 0 replies; 6+ messages in thread
From: Zi Yan @ 2026-09-12 0:09 UTC (permalink / raw)
To: Andrew Morton
Cc: Lorenzo Stoakes (ARM), Jaeyeon Lee, shuah, david, liam, vbabka,
rppt, surenb, mhocko, linux-mm, linux-kselftest, linux-kernel
On 11 Sep 2026, at 19:56, Andrew Morton wrote:
> On Fri, 11 Sep 2026 14:01:55 +0100 "Lorenzo Stoakes (ARM)" <ljs@kernel.org> wrote:
>
>>> Assisted-by: claude.ai:claude-opus-5
>>
>> Convention is now:
>>
>> Assisted-by: LLM
>>
>> See https://docs.kernel.org/process/coding-assistants.html
>
> Yeah. That's so lame. I like seeing what people are using - it's
> interesting.
It is like free advertising for these model[1], like I guessed.
>
> Also tautological. What else will we ever place after
> "Assisted-by: "? Dr Watson?
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=816d9992d9ed434ec52cfbd63080d518e535a41b
Best Regards,
Yan, Zi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] selftests/mm: skip khugepaged file tests if mkfs.xfs is unavailable
2026-09-12 0:06 ` Zi Yan
@ 2026-09-12 13:29 ` Jaeyeon Lee
0 siblings, 0 replies; 6+ messages in thread
From: Jaeyeon Lee @ 2026-09-12 13:29 UTC (permalink / raw)
To: Zi Yan
Cc: akpm, shuah, david, ljs, liam, vbabka, rppt, surenb, mhocko,
linux-mm, linux-kselftest, linux-kernel
On Sat, Sep 12, 2026 at 2:06 AM Zi Yan <ziy@nvidia.com> wrote:
> This might be more robust, since it can detect mkfs.xfs and mount failures.
>
> if grep xfs /proc/filesystems &>/dev/null; then
> XFS_IMG=$(mktemp /tmp/xfs_img_XXXXXX)
> XFS_DIR=$(mktemp -d /tmp/xfs_dir_XXXXXX)
> truncate -s 314572800 ${XFS_IMG}
> if mkfs.xfs -q ${XFS_IMG} && mount -t xfs -o loop ${XFS_IMG} ${XFS_DIR}; then
> SPLIT_HUGE_PAGE_TEST_XFS_PATH=${XFS_DIR}
> MOUNTED_XFS=1
> else
> rmdir ${XFS_DIR}
> rm -f ${XFS_IMG}
> fi
> fi
I'll send v2 with this, adding a Suggested-by: tag and fixing the
Assisted-by: tag format.
Thanks for the review.
Best regards,
Jaeyeon Lee
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-09-12 13:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-11 12:45 [PATCH] selftests/mm: skip khugepaged file tests if mkfs.xfs is unavailable Jaeyeon Lee
2026-09-11 13:01 ` Lorenzo Stoakes (ARM)
2026-09-11 23:56 ` Andrew Morton
2026-09-12 0:09 ` Zi Yan
2026-09-12 0:06 ` Zi Yan
2026-09-12 13:29 ` Jaeyeon Lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox