Linux Kernel Selftest development
 help / color / mirror / Atom feed
* [PATCH net v2] selftests: net: veth: propagate channel-check failures to exit status
@ 2026-11-15 21:47 Omokefe Emmanuel Onanaroghene
  2026-11-16  0:45 ` Tianyi Gao
  0 siblings, 1 reply; 3+ messages in thread
From: Omokefe Emmanuel Onanaroghene @ 2026-11-15 21:47 UTC (permalink / raw)
  To: kuba, tianyi, netdev, linux-kselftest, linux-kernel, bpf
  Cc: davem, edumazet, pabeni, horms, shuah, ast, daniel, hawk,
	john.fastabend, sdf, skhan, Omokefe Emmanuel Onanaroghene

chk_channels() reports mismatches with a "fail" line but never sets
ret, so the script exits 0 even when channel counts are wrong. Every
other check helper in the file (__chk_flag, chk_xdp_feature, chk_gro)
sets ret=1 on failure, and all chk_channels() call sites expect the
check to pass. Set ret=1 on mismatch.

Fixes: 1ec2230fc721 ("selftests: net: veth: add tests for set_channel")
Signed-off-by: Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com>
---
v2: correct Fixes tag (was c017800af5c71, now 1ec2230fc721)

 tools/testing/selftests/net/veth.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/net/veth.sh b/tools/testing/selftests/net/veth.sh
index 64c2a5a59821d..5c1dbe1516bb4 100755
--- a/tools/testing/selftests/net/veth.sh
+++ b/tools/testing/selftests/net/veth.sh
@@ -130,6 +130,7 @@ chk_channels() {
 		echo " ok "
 	else
 		echo " fail rx:$rx:$cur_rx tx:$tx:$cur_tx combined:n/a:$cur_combined"
+		ret=1
 	fi
 }
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH net v2] selftests: net: veth: propagate channel-check failures to exit status
  2026-11-15 21:47 [PATCH net v2] selftests: net: veth: propagate channel-check failures to exit status Omokefe Emmanuel Onanaroghene
@ 2026-11-16  0:45 ` Tianyi Gao
  2026-11-16  0:56   ` Hangbin Liu
  0 siblings, 1 reply; 3+ messages in thread
From: Tianyi Gao @ 2026-11-16  0:45 UTC (permalink / raw)
  To: Omokefe Emmanuel Onanaroghene
  Cc: kuba, netdev, linux-kselftest, linux-kernel, bpf, davem, edumazet,
	pabeni, horms, shuah, ast, daniel, hawk, john.fastabend, sdf,
	skhan

On Sun, 15 Nov 2026 22:47:02 +0100 Omokefe Emmanuel Onanaroghene wrote:
> chk_channels() reports mismatches with a "fail" line but never sets
> ret, so the script exits 0 even when channel counts are wrong.

I found three more checks in the same file with the same problem:

  bad setting: XDP with RX nr less than TX
  bad setting: reducing RX nr below peer TX with XDP set
  bad setting: increasing peer TX nr above RX with XDP set

Maybe it is worth fixing them all at once?

Tested-by: Tianyi Gao <tianyi@cloudflare.com>

Cheers,
Tianyi

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net v2] selftests: net: veth: propagate channel-check failures to exit status
  2026-11-16  0:45 ` Tianyi Gao
@ 2026-11-16  0:56   ` Hangbin Liu
  0 siblings, 0 replies; 3+ messages in thread
From: Hangbin Liu @ 2026-11-16  0:56 UTC (permalink / raw)
  To: Tianyi Gao
  Cc: Omokefe Emmanuel Onanaroghene, kuba, netdev, linux-kselftest,
	linux-kernel, bpf, davem, edumazet, pabeni, horms, shuah, ast,
	daniel, hawk, john.fastabend, sdf, skhan

On Mon, Nov 16, 2026 at 12:45:48AM +0000, Tianyi Gao wrote:
> On Sun, 15 Nov 2026 22:47:02 +0100 Omokefe Emmanuel Onanaroghene wrote:
> > chk_channels() reports mismatches with a "fail" line but never sets
> > ret, so the script exits 0 even when channel counts are wrong.
> 
> I found three more checks in the same file with the same problem:
> 
>   bad setting: XDP with RX nr less than TX
>   bad setting: reducing RX nr below peer TX with XDP set
>   bad setting: increasing peer TX nr above RX with XDP set
> 
> Maybe it is worth fixing them all at once?

+1

> 
> Tested-by: Tianyi Gao <tianyi@cloudflare.com>
> 

Hangbin

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-16  0:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-15 21:47 [PATCH net v2] selftests: net: veth: propagate channel-check failures to exit status Omokefe Emmanuel Onanaroghene
2026-11-16  0:45 ` Tianyi Gao
2026-11-16  0:56   ` Hangbin Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox