* [PATCH net] selftests: net: arp_ndisc_evict_nocarrier: propagate the last test failure
@ 2026-11-15 22:23 Omokefe Emmanuel Onanaroghene
2026-11-16 0:58 ` Hangbin Liu
0 siblings, 1 reply; 2+ messages in thread
From: Omokefe Emmanuel Onanaroghene @ 2026-11-15 22:23 UTC (permalink / raw)
To: netdev, po-hsu.lin, linux-kselftest
Cc: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman, Shuah Khan, linux-kernel, skhan,
Omokefe Emmanuel Onanaroghene
run_arp_evict_nocarrier_disabled_all() reports mismatches with a
"failed" line but never sets ret, so the script exits 0 even when the
all.arp_evict_nocarrier=0 test fails. The 2023 bulk fix wired the
other five test functions and missed this one; the v6 twin
(run_ndisc_evict_nocarrier_disabled_all) already sets ret=1. Set
ret=1 on mismatch.
Fixes: 1856628baa170 ("selftests: net: return non-zero for failures reported in arp_ndisc_evict_nocarrier")
Signed-off-by: Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com>
---
tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh b/tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh
index 00758f00efbfa..4afb953a3e479 100755
--- a/tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh
+++ b/tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh
@@ -139,6 +139,7 @@ run_arp_evict_nocarrier_disabled_all() {
echo "ok"
else
echo "failed"
+ ret=1
fi
cleanup_v4
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] selftests: net: arp_ndisc_evict_nocarrier: propagate the last test failure
2026-11-15 22:23 [PATCH net] selftests: net: arp_ndisc_evict_nocarrier: propagate the last test failure Omokefe Emmanuel Onanaroghene
@ 2026-11-16 0:58 ` Hangbin Liu
0 siblings, 0 replies; 2+ messages in thread
From: Hangbin Liu @ 2026-11-16 0:58 UTC (permalink / raw)
To: Omokefe Emmanuel Onanaroghene
Cc: netdev, po-hsu.lin, linux-kselftest, David S . Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Simon Horman,
Shuah Khan, linux-kernel, skhan
On Sun, Nov 15, 2026 at 11:23:51PM +0100, Omokefe Emmanuel Onanaroghene wrote:
> run_arp_evict_nocarrier_disabled_all() reports mismatches with a
> "failed" line but never sets ret, so the script exits 0 even when the
> all.arp_evict_nocarrier=0 test fails. The 2023 bulk fix wired the
> other five test functions and missed this one; the v6 twin
> (run_ndisc_evict_nocarrier_disabled_all) already sets ret=1. Set
> ret=1 on mismatch.
>
> Fixes: 1856628baa170 ("selftests: net: return non-zero for failures reported in arp_ndisc_evict_nocarrier")
> Signed-off-by: Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com>
> ---
> tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh b/tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh
> index 00758f00efbfa..4afb953a3e479 100755
> --- a/tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh
> +++ b/tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh
> @@ -139,6 +139,7 @@ run_arp_evict_nocarrier_disabled_all() {
> echo "ok"
> else
> echo "failed"
> + ret=1
> fi
>
> cleanup_v4
> --
> 2.43.0
>
Reviewed-by: Hangbin Liu <liuhangbin@kylinos.cn>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-16 0:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-15 22:23 [PATCH net] selftests: net: arp_ndisc_evict_nocarrier: propagate the last test failure Omokefe Emmanuel Onanaroghene
2026-11-16 0:58 ` Hangbin Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox