From: Muhammad Usama Anjum <Usama.Anjum@collabora.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Shuah Khan" <shuah@kernel.org>,
"Reinette Chatre" <reinette.chatre@intel.com>,
linux-kselftest@vger.kernel.org
Cc: Usama.Anjum@collabora.com, linux-kernel@vger.kernel.org,
Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
Fenghua Yu <fenghua.yu@intel.com>
Subject: Re: [PATCH 2/3] selftests/resctrl: Always initialize ecx to avoid build warnings
Date: Thu, 22 Aug 2024 09:49:05 +0500 [thread overview]
Message-ID: <b3f1c35f-093a-4038-9ae9-540bfb58feef@collabora.com> (raw)
In-Reply-To: <20240813104515.19152-3-ilpo.jarvinen@linux.intel.com>
On 8/13/24 3:45 PM, Ilpo Järvinen wrote:
> To avoid warnings when __cpuid_count() is an empty stub, always
> initialize ecx because it is used in the return statement.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> tools/testing/selftests/resctrl/cat_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
> index 51a1cb6aac34..9882c5d19408 100644
> --- a/tools/testing/selftests/resctrl/cat_test.c
> +++ b/tools/testing/selftests/resctrl/cat_test.c
> @@ -290,7 +290,7 @@ static int cat_run_test(const struct resctrl_test *test, const struct user_param
>
> static bool arch_supports_noncont_cat(const struct resctrl_test *test)
> {
> - unsigned int eax, ebx, ecx, edx;
> + unsigned int eax, ebx, ecx = 0, edx;
>
> switch (get_vendor()) {
> case ARCH_AMD:
--
BR,
Muhammad Usama Anjum
next prev parent reply other threads:[~2024-08-22 4:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 10:45 [PATCH 0/3] selftests: Fix cpuid / vendor checking build issues Ilpo Järvinen
2024-08-13 10:45 ` [PATCH 1/3] selftests/resctrl: Generalize non-contiguous CAT check Ilpo Järvinen
2024-08-22 4:48 ` Muhammad Usama Anjum
2024-08-13 10:45 ` [PATCH 2/3] selftests/resctrl: Always initialize ecx to avoid build warnings Ilpo Järvinen
2024-08-22 4:49 ` Muhammad Usama Anjum [this message]
2024-08-13 10:45 ` [RFC PATCH 3/3] kselftest: Provide __cpuid_count() stub on non-x86 archs Ilpo Järvinen
2024-08-22 4:49 ` Muhammad Usama Anjum
2024-08-21 6:30 ` [PATCH 0/3] selftests: Fix cpuid / vendor checking build issues Shuah Khan
2024-08-22 4:51 ` Muhammad Usama Anjum
2024-08-22 7:41 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3f1c35f-093a-4038-9ae9-540bfb58feef@collabora.com \
--to=usama.anjum@collabora.com \
--cc=fenghua.yu@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
--cc=tan.shaopeng@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox