From: Martin KaFai Lau <martin.lau@linux.dev>
To: Geliang Tang <geliang@kernel.org>
Cc: Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Mykola Lysenko <mykolal@fb.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>,
Geliang Tang <tanggeliang@kylinos.cn>,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf-next v6 6/9] selftests/bpf: Use start_server_str in sk_lookup
Date: Wed, 3 Jul 2024 14:53:31 -0700 [thread overview]
Message-ID: <b7d8c5ef-b2de-4d29-b206-f6e7ed79ae99@linux.dev> (raw)
In-Reply-To: <06045a7bd4014d62e762778f149efa837d66b8dc.1719623708.git.tanggeliang@kylinos.cn>
On 6/28/24 6:20 PM, Geliang Tang wrote:
> +static int make_server(int sotype, const char *ip, int port,
> + struct bpf_program *reuseport_prog)
> +{
> + struct cb_opts cb_opts = {
> + .family = is_ipv6(ip) ? AF_INET6 : AF_INET,
> + .sotype = sotype,
> + .reuseport = reuseport_prog,
> + };
> + struct network_helper_opts opts = {
> + .backlog = SOMAXCONN,
> + .post_socket_cb = setsockopts,
> + .cb_opts = &cb_opts,
> + };
> + int err, fd;
> +
> + fd = start_server_str(cb_opts.family, sotype, ip, port, &opts);
> + if (!ASSERT_GT(fd, 0, "start_server_str"))
ASSERT_G(E). probably helpful to add a new ASSERT_OK_FD into the test_progs.h to
avoid this in the future.
> + return -1;
next prev parent reply other threads:[~2024-07-03 21:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-29 1:20 [PATCH bpf-next v6 0/9] use network helpers, part 8 Geliang Tang
2024-06-29 1:20 ` [PATCH bpf-next v6 1/9] selftests/bpf: Add backlog for network_helper_opts Geliang Tang
2024-07-03 21:34 ` Martin KaFai Lau
2024-06-29 1:20 ` [PATCH bpf-next v6 2/9] selftests/bpf: Use start_server_str in sockmap_ktls Geliang Tang
2024-07-03 21:39 ` Martin KaFai Lau
2024-06-29 1:20 ` [PATCH bpf-next v6 3/9] selftests/bpf: Use connect_to_fd " Geliang Tang
2024-07-03 21:47 ` Martin KaFai Lau
2024-06-29 1:20 ` [PATCH bpf-next v6 4/9] selftests/bpf: Use make_sockaddr " Geliang Tang
2024-06-29 1:20 ` [PATCH bpf-next v6 5/9] selftests/bpf: Close fd in error path in drop_on_reuseport Geliang Tang
2024-06-29 1:20 ` [PATCH bpf-next v6 6/9] selftests/bpf: Use start_server_str in sk_lookup Geliang Tang
2024-07-03 21:53 ` Martin KaFai Lau [this message]
2024-06-29 1:20 ` [PATCH bpf-next v6 7/9] selftests/bpf: Use connect_to_fd " Geliang Tang
2024-06-29 1:20 ` [PATCH bpf-next v6 8/9] selftests/bpf: Use connect_to_addr " Geliang Tang
2024-07-03 21:58 ` Martin KaFai Lau
2024-06-29 1:20 ` [PATCH bpf-next v6 9/9] selftests/bpf: Drop make_socket " Geliang Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7d8c5ef-b2de-4d29-b206-f6e7ed79ae99@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=geliang@kernel.org \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mykolal@fb.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=tanggeliang@kylinos.cn \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox