From: Martin KaFai Lau <martin.lau@linux.dev>
To: Geliang Tang <geliang@kernel.org>
Cc: Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Mykola Lysenko <mykolal@fb.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>,
Geliang Tang <tanggeliang@kylinos.cn>,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf-next v6 2/9] selftests/bpf: Use start_server_str in sockmap_ktls
Date: Wed, 3 Jul 2024 14:39:44 -0700 [thread overview]
Message-ID: <16e5a48e-3261-4e8f-a4f3-0e4b9cb16482@linux.dev> (raw)
In-Reply-To: <549f4b0a22ee953a57ebd3d96a5a6619e881b110.1719623708.git.tanggeliang@kylinos.cn>
On 6/28/24 6:20 PM, Geliang Tang wrote:
> static void test_sockmap_ktls_disconnect_after_delete(int family, int map)
> {
> + struct network_helper_opts opts = {
> + .backlog = SOMAXCONN,
> + };
> struct sockaddr_storage addr = {0};
> socklen_t len = sizeof(addr);
> int err, cli, srv, zero = 0;
>
> - srv = tcp_server(family);
> + srv = start_server_str(family, SOCK_STREAM, NULL, 0, &opts);
> if (srv == -1)
It should be "if (!ASSERT_GE(srv, 0, ...))" to ensure that the failure is caught
by the test_progs.
next prev parent reply other threads:[~2024-07-03 21:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-29 1:20 [PATCH bpf-next v6 0/9] use network helpers, part 8 Geliang Tang
2024-06-29 1:20 ` [PATCH bpf-next v6 1/9] selftests/bpf: Add backlog for network_helper_opts Geliang Tang
2024-07-03 21:34 ` Martin KaFai Lau
2024-06-29 1:20 ` [PATCH bpf-next v6 2/9] selftests/bpf: Use start_server_str in sockmap_ktls Geliang Tang
2024-07-03 21:39 ` Martin KaFai Lau [this message]
2024-06-29 1:20 ` [PATCH bpf-next v6 3/9] selftests/bpf: Use connect_to_fd " Geliang Tang
2024-07-03 21:47 ` Martin KaFai Lau
2024-06-29 1:20 ` [PATCH bpf-next v6 4/9] selftests/bpf: Use make_sockaddr " Geliang Tang
2024-06-29 1:20 ` [PATCH bpf-next v6 5/9] selftests/bpf: Close fd in error path in drop_on_reuseport Geliang Tang
2024-06-29 1:20 ` [PATCH bpf-next v6 6/9] selftests/bpf: Use start_server_str in sk_lookup Geliang Tang
2024-07-03 21:53 ` Martin KaFai Lau
2024-06-29 1:20 ` [PATCH bpf-next v6 7/9] selftests/bpf: Use connect_to_fd " Geliang Tang
2024-06-29 1:20 ` [PATCH bpf-next v6 8/9] selftests/bpf: Use connect_to_addr " Geliang Tang
2024-07-03 21:58 ` Martin KaFai Lau
2024-06-29 1:20 ` [PATCH bpf-next v6 9/9] selftests/bpf: Drop make_socket " Geliang Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16e5a48e-3261-4e8f-a4f3-0e4b9cb16482@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=geliang@kernel.org \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mykolal@fb.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=tanggeliang@kylinos.cn \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox