From: Dave Hansen <dave.hansen@intel.com>
To: Sathyanarayanan Kuppuswamy
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Wander Lairson Costa <wander@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, Shuah Khan <shuah@kernel.org>,
"H . Peter Anvin" <hpa@zytor.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Tony Luck <tony.luck@intel.com>, Andi Kleen <ak@linux.intel.com>,
Kai Huang <kai.huang@intel.com>,
Isaku Yamahata <isaku.yamahata@gmail.com>,
marcelo.cerri@canonical.com, tim.gardner@canonical.com,
khalid.elmously@canonical.com, philip.cox@canonical.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v12 2/3] selftests: tdx: Test TDX attestation GetReport support
Date: Fri, 9 Sep 2022 06:49:57 -0700 [thread overview]
Message-ID: <bd3988e8-dc15-9a81-1de4-560e86d36398@intel.com> (raw)
In-Reply-To: <e4b6f718-d671-72b3-4c4d-4338feba80a1@linux.intel.com>
On 9/8/22 18:55, Sathyanarayanan Kuppuswamy wrote:
> +#ifdef DEBUG
> +#define pr_debug(...) printf(__VA_ARGS__)
> +#else
> +#define pr_debug(...) _no_printf(__VA_ARGS__)
> +#endif
If you're going this way, please put this in common selftest code.
Don't force every single test to duplicate it.
But, seriously, this is all insanity. Fixing the whole "oh, but DEBUG
might not be defined" thing is not exactly rocket science. Just do this
in your test header or .c file:
#ifndef DEBUG
#define DEBUG 0
#endif
Then you can do:
if (DEBUG)
foo();
all day long.
Or, not. I honestly don't think this is worth even mucking with in the
first place.
next prev parent reply other threads:[~2022-09-09 13:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 0:27 [PATCH v12 0/3] Add TDX Guest Attestation support Kuppuswamy Sathyanarayanan
2022-09-08 0:27 ` [PATCH v12 1/3] x86/tdx: Add TDX Guest attestation interface driver Kuppuswamy Sathyanarayanan
2022-09-08 5:31 ` Greg Kroah-Hartman
2022-09-08 19:07 ` Sathyanarayanan Kuppuswamy
2022-09-08 20:36 ` Dave Hansen
2022-09-08 20:45 ` Sathyanarayanan Kuppuswamy
2022-09-09 5:26 ` Greg Kroah-Hartman
2022-09-08 23:53 ` Sathyanarayanan Kuppuswamy
2022-09-09 5:25 ` Greg Kroah-Hartman
2022-09-08 0:27 ` [PATCH v12 2/3] selftests: tdx: Test TDX attestation GetReport support Kuppuswamy Sathyanarayanan
2022-09-08 14:16 ` Wander Lairson Costa
2022-09-08 23:45 ` Sathyanarayanan Kuppuswamy
2022-09-09 13:36 ` Wander Lairson Costa
2022-09-09 18:40 ` Sathyanarayanan Kuppuswamy
2022-09-09 1:55 ` Sathyanarayanan Kuppuswamy
2022-09-09 13:49 ` Dave Hansen [this message]
2022-09-09 3:48 ` Huang, Kai
2022-09-09 5:08 ` Sathyanarayanan Kuppuswamy
2022-09-08 0:27 ` [PATCH v12 3/3] Documentation/x86: Document TDX attestation process Kuppuswamy Sathyanarayanan
2022-09-08 9:10 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd3988e8-dc15-9a81-1de4-560e86d36398@intel.com \
--to=dave.hansen@intel.com \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=isaku.yamahata@gmail.com \
--cc=kai.huang@intel.com \
--cc=khalid.elmously@canonical.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=marcelo.cerri@canonical.com \
--cc=mingo@redhat.com \
--cc=philip.cox@canonical.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tim.gardner@canonical.com \
--cc=tony.luck@intel.com \
--cc=wander@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox