From: Paolo Abeni <pabeni@redhat.com>
To: Zhengchao Shao <shaozhengchao@huawei.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
shuah@kernel.org
Cc: j.vosburgh@gmail.com, andy@greyhouse.net, weiyongjun1@huawei.com,
yuehaibing@huawei.com
Subject: Re: [PATCH net-next] selftests: bonding: delete link1_1 in the cleanup path
Date: Thu, 24 Aug 2023 12:31:04 +0200 [thread overview]
Message-ID: <c25141405ba52eb0eee96317407376ef68802198.camel@redhat.com> (raw)
In-Reply-To: <20230823032640.3609934-1-shaozhengchao@huawei.com>
On Wed, 2023-08-23 at 11:26 +0800, Zhengchao Shao wrote:
> If failed to set link1_1 to netns client, we should delete link1_1 in the
> cleanup path. But if set link1_1 to netns client successfully, delete
> link1_1 will report warning. So delete link1_1 in the cleanup path and
> drop any warning message.
I think the same could happen also for the link1_2 device.
It would probably be safer creating directly the devices in the target
namespaces, with the 'final' name
ip link add dev eth0 netns client type veth peer name eth0 netns server
Cheers,
Paolo
next prev parent reply other threads:[~2023-08-24 10:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 3:26 [PATCH net-next] selftests: bonding: delete link1_1 in the cleanup path Zhengchao Shao
2023-08-24 8:50 ` Simon Horman
2023-08-24 10:31 ` Paolo Abeni [this message]
2023-08-24 13:25 ` shaozhengchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c25141405ba52eb0eee96317407376ef68802198.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=andy@greyhouse.net \
--cc=j.vosburgh@gmail.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shaozhengchao@huawei.com \
--cc=shuah@kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox