From: shaozhengchao <shaozhengchao@huawei.com>
To: Paolo Abeni <pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>, <shuah@kernel.org>
Cc: <j.vosburgh@gmail.com>, <andy@greyhouse.net>,
<weiyongjun1@huawei.com>, <yuehaibing@huawei.com>
Subject: Re: [PATCH net-next] selftests: bonding: delete link1_1 in the cleanup path
Date: Thu, 24 Aug 2023 21:25:23 +0800 [thread overview]
Message-ID: <d1b227e7-0653-da6c-a8b6-0e97121bb847@huawei.com> (raw)
In-Reply-To: <c25141405ba52eb0eee96317407376ef68802198.camel@redhat.com>
On 2023/8/24 18:31, Paolo Abeni wrote:
> On Wed, 2023-08-23 at 11:26 +0800, Zhengchao Shao wrote:
>> If failed to set link1_1 to netns client, we should delete link1_1 in the
>> cleanup path. But if set link1_1 to netns client successfully, delete
>> link1_1 will report warning. So delete link1_1 in the cleanup path and
>> drop any warning message.
>
> I think the same could happen also for the link1_2 device.
>
> It would probably be safer creating directly the devices in the target
> namespaces, with the 'final' name
>
> ip link add dev eth0 netns client type veth peer name eth0 netns server
>
> Cheers,
>
> Paolo
>
Yeah, it looks good, I will send v2.
Thank you.
Zhengchao Shao
prev parent reply other threads:[~2023-08-24 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 3:26 [PATCH net-next] selftests: bonding: delete link1_1 in the cleanup path Zhengchao Shao
2023-08-24 8:50 ` Simon Horman
2023-08-24 10:31 ` Paolo Abeni
2023-08-24 13:25 ` shaozhengchao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1b227e7-0653-da6c-a8b6-0e97121bb847@huawei.com \
--to=shaozhengchao@huawei.com \
--cc=andy@greyhouse.net \
--cc=j.vosburgh@gmail.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).