Linux Kernel Selftest development
 help / color / mirror / Atom feed
* [PATCH -next 1/2] selftests:timers: remove unneeded semicolon
@ 2024-10-17  6:27 Jiapeng Chong
  2024-10-17  6:27 ` [PATCH -next 2/2] " Jiapeng Chong
  2024-10-17 15:43 ` [PATCH -next 1/2] " Shuah Khan
  0 siblings, 2 replies; 4+ messages in thread
From: Jiapeng Chong @ 2024-10-17  6:27 UTC (permalink / raw)
  To: anna-maria
  Cc: frederic, tglx, jstultz, sboyd, shuah, linux-kernel,
	linux-kselftest, Jiapeng Chong, Abaci Robot

No functional modification involved.

./tools/testing/selftests/timers/nanosleep.c:63:2-3: Unneeded semicolon.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11407
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 tools/testing/selftests/timers/nanosleep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/timers/nanosleep.c b/tools/testing/selftests/timers/nanosleep.c
index 252c6308c569..36f9b97f232a 100644
--- a/tools/testing/selftests/timers/nanosleep.c
+++ b/tools/testing/selftests/timers/nanosleep.c
@@ -60,7 +60,7 @@ char *clockstring(int clockid)
 		return "CLOCK_BOOTTIME_ALARM";
 	case CLOCK_TAI:
 		return "CLOCK_TAI";
-	};
+	}
 	return "UNKNOWN_CLOCKID";
 }
 
-- 
2.32.0.3.g01195cf9f


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH -next 2/2] selftests:timers: remove unneeded semicolon
  2024-10-17  6:27 [PATCH -next 1/2] selftests:timers: remove unneeded semicolon Jiapeng Chong
@ 2024-10-17  6:27 ` Jiapeng Chong
  2024-10-17 15:45   ` Shuah Khan
  2024-10-17 15:43 ` [PATCH -next 1/2] " Shuah Khan
  1 sibling, 1 reply; 4+ messages in thread
From: Jiapeng Chong @ 2024-10-17  6:27 UTC (permalink / raw)
  To: anna-maria
  Cc: frederic, tglx, jstultz, sboyd, shuah, linux-kernel,
	linux-kselftest, Jiapeng Chong, Abaci Robot

No functional modification involved.

./tools/testing/selftests/timers/nsleep-lat.c:62:2-3: Unneeded semicolon.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11406
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 tools/testing/selftests/timers/nsleep-lat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/timers/nsleep-lat.c b/tools/testing/selftests/timers/nsleep-lat.c
index de23dc0c9f97..6f7f7d682439 100644
--- a/tools/testing/selftests/timers/nsleep-lat.c
+++ b/tools/testing/selftests/timers/nsleep-lat.c
@@ -59,7 +59,7 @@ char *clockstring(int clockid)
 		return "CLOCK_BOOTTIME_ALARM";
 	case CLOCK_TAI:
 		return "CLOCK_TAI";
-	};
+	}
 	return "UNKNOWN_CLOCKID";
 }
 
-- 
2.32.0.3.g01195cf9f


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH -next 1/2] selftests:timers: remove unneeded semicolon
  2024-10-17  6:27 [PATCH -next 1/2] selftests:timers: remove unneeded semicolon Jiapeng Chong
  2024-10-17  6:27 ` [PATCH -next 2/2] " Jiapeng Chong
@ 2024-10-17 15:43 ` Shuah Khan
  1 sibling, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2024-10-17 15:43 UTC (permalink / raw)
  To: Jiapeng Chong, anna-maria
  Cc: frederic, tglx, jstultz, sboyd, shuah, linux-kernel,
	linux-kselftest, Abaci Robot, Shuah Khan

On 10/17/24 00:27, Jiapeng Chong wrote:
> No functional modification involved.

Please include the report details in the change log
> 
> ./tools/testing/selftests/timers/nanosleep.c:63:2-3: Unneeded semicolon.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11407
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   tools/testing/selftests/timers/nanosleep.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/timers/nanosleep.c b/tools/testing/selftests/timers/nanosleep.c
> index 252c6308c569..36f9b97f232a 100644
> --- a/tools/testing/selftests/timers/nanosleep.c
> +++ b/tools/testing/selftests/timers/nanosleep.c
> @@ -60,7 +60,7 @@ char *clockstring(int clockid)
>   		return "CLOCK_BOOTTIME_ALARM";
>   	case CLOCK_TAI:
>   		return "CLOCK_TAI";
> -	};
> +	}
>   	return "UNKNOWN_CLOCKID";
>   }
>   

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -next 2/2] selftests:timers: remove unneeded semicolon
  2024-10-17  6:27 ` [PATCH -next 2/2] " Jiapeng Chong
@ 2024-10-17 15:45   ` Shuah Khan
  0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2024-10-17 15:45 UTC (permalink / raw)
  To: Jiapeng Chong, anna-maria
  Cc: frederic, tglx, jstultz, sboyd, shuah, linux-kernel,
	linux-kselftest, Abaci Robot, Shuah Khan

On 10/17/24 00:27, Jiapeng Chong wrote:
> No functional modification involved.
> 
> ./tools/testing/selftests/timers/nsleep-lat.c:62:2-3: Unneeded semicolon.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11406
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   tools/testing/selftests/timers/nsleep-lat.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/timers/nsleep-lat.c b/tools/testing/selftests/timers/nsleep-lat.c
> index de23dc0c9f97..6f7f7d682439 100644
> --- a/tools/testing/selftests/timers/nsleep-lat.c
> +++ b/tools/testing/selftests/timers/nsleep-lat.c
> @@ -59,7 +59,7 @@ char *clockstring(int clockid)
>   		return "CLOCK_BOOTTIME_ALARM";
>   	case CLOCK_TAI:
>   		return "CLOCK_TAI";
> -	};
> +	}
>   	return "UNKNOWN_CLOCKID";
>   }
>   

This is the same change. same comment on this one too.
I am working on deleting the duplicate code and there
is no need to make these changes.

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-10-17 15:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-17  6:27 [PATCH -next 1/2] selftests:timers: remove unneeded semicolon Jiapeng Chong
2024-10-17  6:27 ` [PATCH -next 2/2] " Jiapeng Chong
2024-10-17 15:45   ` Shuah Khan
2024-10-17 15:43 ` [PATCH -next 1/2] " Shuah Khan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox