From: Andrew Lunn <andrew@lunn.ch>
To: Michal Rostecki <vadorovsky@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Brendan Higgins" <brendan.higgins@linux.dev>,
"David Gow" <davidgow@google.com>, "Rae Moar" <rmoar@google.com>,
"FUJITA Tomonori" <fujita.tomonori@gmail.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>,
"Martin Rodriguez Reboredo" <yakoyoku@gmail.com>,
"Manmohan Shukla" <manmshuk@gmail.com>,
"Valentin Obst" <kernel@valentinobst.de>,
"Yutaro Ohno" <yutaro.ono.418@gmail.com>,
"Danilo Krummrich" <dakr@redhat.com>,
"Charalampos Mitrodimas" <charmitro@posteo.net>,
"Ben Gooding" <ben.gooding.dev@gmail.com>,
"Tejun Heo" <tj@kernel.org>,
"Nell Shamrell-Harrington" <nells@linux.microsoft.com>,
"Roland Xu" <mu001999@outlook.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
netdev@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH v5] rust: str: Use `core::CStr`, remove the custom `CStr` implementation
Date: Thu, 18 Jul 2024 04:06:46 +0200 [thread overview]
Message-ID: <d63e56d7-368f-42ec-bcee-605289c974cb@lunn.ch> (raw)
In-Reply-To: <20240717160339.146371-2-vadorovsky@gmail.com>
> v3 -> v4:
> - Provide the `CStrExt` trait with `display()` method, which returns a
> `CStrDisplay` wrapper with `Display` implementation. This addresses
> the lack of `Display` implementation for `core::ffi::CStr`.
> - Provide `from_bytes_with_nul_unchecked_mut()` method in `CStrExt`,
> which might be useful and is going to prevent manual, unsafe casts.
> - Fix a typo (s/preffered/prefered/).
>
> v4 -> v5:
> - Keep the `test_cstr_display*` unit tests.
Please take a read of:
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
In particular, the bit about 24 hours, and the merge window.
Thanks
Andrew
---
pw-bot: cr
prev parent reply other threads:[~2024-07-18 2:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 16:03 [PATCH v5] rust: str: Use `core::CStr`, remove the custom `CStr` implementation Michal Rostecki
2024-07-18 2:06 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d63e56d7-368f-42ec-bcee-605289c974cb@lunn.ch \
--to=andrew@lunn.ch \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=ben.gooding.dev@gmail.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=brendan.higgins@linux.dev \
--cc=charmitro@posteo.net \
--cc=dakr@redhat.com \
--cc=davidgow@google.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=justinstitt@google.com \
--cc=kernel@valentinobst.de \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=manmshuk@gmail.com \
--cc=morbo@google.com \
--cc=mu001999@outlook.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nells@linux.microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rmoar@google.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tj@kernel.org \
--cc=tmgross@umich.edu \
--cc=vadorovsky@gmail.com \
--cc=wedsonaf@gmail.com \
--cc=yakoyoku@gmail.com \
--cc=yutaro.ono.418@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox