Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Madhur Kumar <madhurkumar004@gmail.com>, shuah@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 1/2] selftests/acct: add cleanup for leftover process_log binary
Date: Wed, 24 Sep 2025 17:24:44 -0600	[thread overview]
Message-ID: <d8df684e-0c09-44ea-87a4-cdbaf65ab0b8@linuxfoundation.org> (raw)
In-Reply-To: <20250922091042.149117-1-madhurkumar004@gmail.com>

On 9/22/25 03:10, Madhur Kumar wrote:
> Some kselftests generate temporary binaries that are not tracked
> by TEST_GEN_PROGS. Add EXTRA_CLEAN entry to remove process_log
> during `make kselftest-clean`.
> 
> Signed-off-by: Madhur Kumar <madhurkumar004@gmail.com>
> ---
>   tools/testing/selftests/acct/Makefile | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/acct/Makefile b/tools/testing/selftests/acct/Makefile
> index 7e025099cf65..16eb97079e63 100644
> --- a/tools/testing/selftests/acct/Makefile
> +++ b/tools/testing/selftests/acct/Makefile
> @@ -1,5 +1,6 @@
>   # SPDX-License-Identifier: GPL-2.0
>   TEST_GEN_PROGS := acct_syscall
>   CFLAGS += -Wall
> +EXTRA_CLEAN := process_log
>   
> -include ../lib.mk
> \ No newline at end of file

> +include ../lib.mk

Why is this deleted and added back

Please fix the patch and send v2.

thanks,
-- Shuah


  parent reply	other threads:[~2025-09-24 23:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-22  9:10 [PATCH 1/2] selftests/acct: add cleanup for leftover process_log binary Madhur Kumar
2025-09-22  9:10 ` [PATCH 2/2] selftests/cachestat: add cleanup for leftover tmpshmcstat binary Madhur Kumar
2025-09-25 19:35   ` Shuah Khan
2025-09-24 23:24 ` Shuah Khan [this message]
2025-09-25  7:46   ` [PATCH 1/2] selftests/acct: add cleanup for leftover process_log binary Madhur Kumar
2025-09-25  8:34   ` [PATCH v2 " Madhur Kumar
2025-09-25 19:23     ` Shuah Khan
2025-09-26 21:26 ` [PATCH v3 " Madhur Kumar
2025-09-27 16:11 ` [PATCH v2 2/2] selftests/cachestat: add cleanup for leftover tmpshmcstat file Madhur Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8df684e-0c09-44ea-87a4-cdbaf65ab0b8@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=madhurkumar004@gmail.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox