From: Shuah Khan <skhan@linuxfoundation.org>
To: Madhur Kumar <madhurkumar004@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
shuah@kernel.org, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 1/2] selftests/acct: add cleanup for leftover process_log binary
Date: Thu, 25 Sep 2025 13:23:44 -0600 [thread overview]
Message-ID: <fd575fd2-f246-469d-9276-bb746b554e19@linuxfoundation.org> (raw)
In-Reply-To: <20250925083445.172571-1-madhurkumar004@gmail.com>
On 9/25/25 02:34, Madhur Kumar wrote:
> Some kselftests generate temporary binaries that are not tracked
> by TEST_GEN_PROGS. Add EXTRA_CLEAN entry to remove process_log
> during `make kselftest-clean`.
>
This information below doesn't belong in the change log
> v2:
> - Fix newline issue at end of Makefile (caused add/delete in git diff)
> - Code otherwise unchanged
>
> Signed-off-by: Madhur Kumar <madhurkumar004@gmail.com>
> ---
Add patch version information here.
> tools/testing/selftests/acct/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/acct/Makefile b/tools/testing/selftests/acct/Makefile
> index 7e025099cf65..fd14128bbddb 100644
> --- a/tools/testing/selftests/acct/Makefile
> +++ b/tools/testing/selftests/acct/Makefile
> @@ -1,5 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0
> TEST_GEN_PROGS := acct_syscall
> CFLAGS += -Wall
> +EXTRA_CLEAN := process_log
>
> include ../lib.mk
This line below is still odd.
> \ No newline at end of file
Start without any changes, make the change, commit, and send
v3. Refer to a few patches on the mailing list for examples
on where the patch version information should be added.
thanks,
-- Shuah
next prev parent reply other threads:[~2025-09-25 19:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 9:10 [PATCH 1/2] selftests/acct: add cleanup for leftover process_log binary Madhur Kumar
2025-09-22 9:10 ` [PATCH 2/2] selftests/cachestat: add cleanup for leftover tmpshmcstat binary Madhur Kumar
2025-09-25 19:35 ` Shuah Khan
2025-09-24 23:24 ` [PATCH 1/2] selftests/acct: add cleanup for leftover process_log binary Shuah Khan
2025-09-25 7:46 ` Madhur Kumar
2025-09-25 8:34 ` [PATCH v2 " Madhur Kumar
2025-09-25 19:23 ` Shuah Khan [this message]
2025-09-26 21:26 ` [PATCH v3 " Madhur Kumar
2025-09-27 16:11 ` [PATCH v2 2/2] selftests/cachestat: add cleanup for leftover tmpshmcstat file Madhur Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd575fd2-f246-469d-9276-bb746b554e19@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=madhurkumar004@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox