* [PATCH] selftests/bpf: Add missing va_end.
@ 2024-09-24 4:55 zhangjiao2
2024-09-24 11:09 ` Eduard Zingerman
2024-09-25 10:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: zhangjiao2 @ 2024-09-24 4:55 UTC (permalink / raw)
To: andrii; +Cc: eddyz87, shuah, bpf, linux-kselftest, linux-kernel, zhang jiao
From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
There is no va_end after va_copy, just add it.
Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
---
tools/testing/selftests/bpf/test_progs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c
index c7a70e1a1085..7846f7f98908 100644
--- a/tools/testing/selftests/bpf/test_progs.c
+++ b/tools/testing/selftests/bpf/test_progs.c
@@ -868,6 +868,7 @@ static int libbpf_print_fn(enum libbpf_print_level level,
va_copy(args2, args);
vfprintf(libbpf_capture_stream, format, args2);
+ va_end(args2);
}
if (env.verbosity < VERBOSE_VERY && level == LIBBPF_DEBUG)
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/bpf: Add missing va_end.
2024-09-24 4:55 [PATCH] selftests/bpf: Add missing va_end zhangjiao2
@ 2024-09-24 11:09 ` Eduard Zingerman
2024-09-25 10:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Eduard Zingerman @ 2024-09-24 11:09 UTC (permalink / raw)
To: zhangjiao2, andrii; +Cc: shuah, bpf, linux-kselftest, linux-kernel
On Tue, 2024-09-24 at 12:55 +0800, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
>
> There is no va_end after va_copy, just add it.
>
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> ---
My bad, thank you for fixing this.
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/bpf: Add missing va_end.
2024-09-24 4:55 [PATCH] selftests/bpf: Add missing va_end zhangjiao2
2024-09-24 11:09 ` Eduard Zingerman
@ 2024-09-25 10:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-09-25 10:10 UTC (permalink / raw)
To: zhangjiao2; +Cc: andrii, eddyz87, shuah, bpf, linux-kselftest, linux-kernel
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:
On Tue, 24 Sep 2024 12:55:34 +0800 you wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
>
> There is no va_end after va_copy, just add it.
>
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> ---
> tools/testing/selftests/bpf/test_progs.c | 1 +
> 1 file changed, 1 insertion(+)
Here is the summary with links:
- selftests/bpf: Add missing va_end.
https://git.kernel.org/bpf/bpf-next/c/8714495755fd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-25 10:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-24 4:55 [PATCH] selftests/bpf: Add missing va_end zhangjiao2
2024-09-24 11:09 ` Eduard Zingerman
2024-09-25 10:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox