* [PATCH] leds: lp8860: Constify reg_default tables
@ 2015-07-08 2:43 Axel Lin
2015-07-13 12:50 ` Jacek Anaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2015-07-08 2:43 UTC (permalink / raw)
To: Bryan Wu; +Cc: Jacek Anaszewski, Dan Murphy, linux-leds
These reg_default tables are not modified after initialized, so make them
const.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/leds/leds-lp8860.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/leds/leds-lp8860.c b/drivers/leds/leds-lp8860.c
index 8c2b7fb..79f0843 100644
--- a/drivers/leds/leds-lp8860.c
+++ b/drivers/leds/leds-lp8860.c
@@ -302,7 +302,7 @@ out:
return ret;
}
-static struct reg_default lp8860_reg_defs[] = {
+static const struct reg_default lp8860_reg_defs[] = {
{ LP8860_DISP_CL1_BRT_MSB, 0x00},
{ LP8860_DISP_CL1_BRT_LSB, 0x00},
{ LP8860_DISP_CL1_CURR_MSB, 0x00},
@@ -332,7 +332,7 @@ static const struct regmap_config lp8860_regmap_config = {
.cache_type = REGCACHE_NONE,
};
-static struct reg_default lp8860_eeprom_defs[] = {
+static const struct reg_default lp8860_eeprom_defs[] = {
{ LP8860_EEPROM_REG_0, 0x00 },
{ LP8860_EEPROM_REG_1, 0x00 },
{ LP8860_EEPROM_REG_2, 0x00 },
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] leds: lp8860: Constify reg_default tables
2015-07-08 2:43 [PATCH] leds: lp8860: Constify reg_default tables Axel Lin
@ 2015-07-13 12:50 ` Jacek Anaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Jacek Anaszewski @ 2015-07-13 12:50 UTC (permalink / raw)
To: Axel Lin; +Cc: Bryan Wu, Dan Murphy, linux-leds
Hi Axel,
Thanks for the patch.
On 07/08/2015 04:43 AM, Axel Lin wrote:
> These reg_default tables are not modified after initialized, so make them
> const.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/leds/leds-lp8860.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-lp8860.c b/drivers/leds/leds-lp8860.c
> index 8c2b7fb..79f0843 100644
> --- a/drivers/leds/leds-lp8860.c
> +++ b/drivers/leds/leds-lp8860.c
> @@ -302,7 +302,7 @@ out:
> return ret;
> }
>
> -static struct reg_default lp8860_reg_defs[] = {
> +static const struct reg_default lp8860_reg_defs[] = {
> { LP8860_DISP_CL1_BRT_MSB, 0x00},
> { LP8860_DISP_CL1_BRT_LSB, 0x00},
> { LP8860_DISP_CL1_CURR_MSB, 0x00},
> @@ -332,7 +332,7 @@ static const struct regmap_config lp8860_regmap_config = {
> .cache_type = REGCACHE_NONE,
> };
>
> -static struct reg_default lp8860_eeprom_defs[] = {
> +static const struct reg_default lp8860_eeprom_defs[] = {
> { LP8860_EEPROM_REG_0, 0x00 },
> { LP8860_EEPROM_REG_1, 0x00 },
> { LP8860_EEPROM_REG_2, 0x00 },
>
Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>
--
Best Regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-13 12:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-08 2:43 [PATCH] leds: lp8860: Constify reg_default tables Axel Lin
2015-07-13 12:50 ` Jacek Anaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox