From: Antonio Ospite <ao2@ao2.it>
To: linux-leds@vger.kernel.org
Cc: Antonio Ospite <ao2@ao2.it>, Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <j.anaszewski@samsung.com>
Subject: [PATCHv2] leds: lp3944: improve wording and formatting in a comment
Date: Thu, 28 Jan 2016 16:49:29 +0100 [thread overview]
Message-ID: <1453996169-18124-1-git-send-email-ao2@ao2.it> (raw)
In-Reply-To: <56A9C4D6.5000505@samsung.com>
Improve the wording for the comment about the led status, and while at
it also use the standard formatting for multi-line comments.
Signed-off-by: Antonio Ospite <ao2@ao2.it>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
---
Changes since v1:
- make the comment more explicit as suggested by Jacek
drivers/leds/leds-lp3944.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/leds/leds-lp3944.c b/drivers/leds/leds-lp3944.c
index 6c758ae..be60c18 100644
--- a/drivers/leds/leds-lp3944.c
+++ b/drivers/leds/leds-lp3944.c
@@ -199,8 +199,11 @@ static int lp3944_led_set(struct lp3944_led_data *led, u8 status)
if (status > LP3944_LED_STATUS_DIM1)
return -EINVAL;
- /* invert only 0 and 1, leave unchanged the other values,
- * remember we are abusing status to set blink patterns
+ /*
+ * Invert status only when it's < 2 (i.e. 0 or 1) which means it's
+ * controlling the on/off state directly.
+ * When, instead, status is >= 2 don't invert it because it would mean
+ * to mess with the hardware blinking mode.
*/
if (led->type == LP3944_LED_TYPE_LED_INVERTED && status < 2)
status = 1 - status;
--
2.7.0
next prev parent reply other threads:[~2016-01-28 15:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 14:31 [PATCH] leds: lp3944: improve wording and formatting in a comment Antonio Ospite
2016-01-27 14:56 ` Jacek Anaszewski
2016-01-27 16:31 ` Antonio Ospite
2016-01-28 7:35 ` Jacek Anaszewski
2016-01-28 15:49 ` Antonio Ospite [this message]
2016-01-29 8:34 ` [PATCHv2] " Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453996169-18124-1-git-send-email-ao2@ao2.it \
--to=ao2@ao2.it \
--cc=j.anaszewski@samsung.com \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox