Re: [PATCHv2] leds: lp3944: improve wording and formatting in a comment

[Jacek Anaszewski <j.anaszewski@samsung.com>]

On 01/28/2016 04:49 PM, Antonio Ospite wrote:
> Improve the wording for the comment about the led status, and while at
> it also use the standard formatting for multi-line comments.
>
> Signed-off-by: Antonio Ospite <ao2@ao2.it>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
> ---
>
> Changes since v1:
>    - make the comment more explicit as suggested by Jacek
>
>   drivers/leds/leds-lp3944.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-lp3944.c b/drivers/leds/leds-lp3944.c
> index 6c758ae..be60c18 100644
> --- a/drivers/leds/leds-lp3944.c
> +++ b/drivers/leds/leds-lp3944.c
> @@ -199,8 +199,11 @@ static int lp3944_led_set(struct lp3944_led_data *led, u8 status)
>   	if (status > LP3944_LED_STATUS_DIM1)
>   		return -EINVAL;
>
> -	/* invert only 0 and 1, leave unchanged the other values,
> -	 * remember we are abusing status to set blink patterns
> +	/*
> +	 * Invert status only when it's < 2 (i.e. 0 or 1) which means it's
> +	 * controlling the on/off state directly.
> +	 * When, instead, status is >= 2 don't invert it because it would mean
> +	 * to mess with the hardware blinking mode.
>   	 */
>   	if (led->type == LP3944_LED_TYPE_LED_INVERTED && status < 2)
>   		status = 1 - status;
>

Applied, thanks.

-- 
Best Regards,
Jacek Anaszewski