Linux LED subsystem development
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Richard Purdie <rpurdie@rpsys.net>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	linux-leds@vger.kernel.org, sakari.ailus@iki.fi
Subject: Re: [PATCH v1] leds: Clarify supported chips by LM355x driver
Date: Sun, 28 Jan 2018 16:18:54 +0200	[thread overview]
Message-ID: <1517149134.7000.1284.camel@linux.intel.com> (raw)
In-Reply-To: <20180126213238.GA10985@amd>

On Fri, 2018-01-26 at 22:32 +0100, Pavel Machek wrote:
> On Fri 2018-01-26 11:25:07, Pavel Machek wrote:

> Actually, what about this?

Works for me:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Though one typo below.

> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 318a28f..2acf864 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -69,7 +69,7 @@ config LEDS_APU
>  	  module will be called leds-apu.
>  
>  config LEDS_AS3645A
> -	tristate "AS3645A LED flash controller support"
> +	tristate "AS3645A and LM3555 LED flash controller support"

controller -> controllers

>  	depends on I2C && LEDS_CLASS_FLASH
>  	depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
>  	help
> @@ -587,12 +587,12 @@ config LEDS_MAX8997
>  	  MAXIM MAX8997 PMIC.
>  
>  config LEDS_LM355x
> -	tristate "LED support for LM355x Chips, LM3554 and LM3556"
> +	tristate "LED support for LM3554 and LM3556 chips"
>  	depends on LEDS_CLASS && I2C
>  	select REGMAP_I2C
>  	help
> -	  This option enables support for LEDs connected to LM355x.
> -	  LM355x includes Torch, Flash and Indicator functions.
> +	  This option enables support for LEDs connected to LM3554
> +	  and lM3556. It includes Torch, Flash and Indicator
> functions.
>  
>  config LEDS_OT200
>  	tristate "LED support for the Bachmann OT200"
> 
> 
> 
> 
> 
> 

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  parent reply	other threads:[~2018-01-28 14:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-26  7:38 [PATCH v1] leds: Clarify supported chips by LM355x driver Andy Shevchenko
2018-01-26 10:25 ` Pavel Machek
2018-01-26 11:44   ` Andy Shevchenko
2018-01-26 21:05     ` Pavel Machek
2018-01-26 21:32   ` Pavel Machek
2018-01-26 22:07     ` Sakari Ailus
2018-01-28 14:18     ` Andy Shevchenko [this message]
2018-01-26 20:39 ` Jacek Anaszewski
2018-01-28 14:30   ` Andy Shevchenko
2018-01-29 20:46     ` Jacek Anaszewski
2018-01-30 11:08       ` Andy Shevchenko
2018-01-30 20:04         ` Jacek Anaszewski
2018-02-01 20:26           ` [PATCH v2] " Pavel Machek
2018-02-01 21:33             ` Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517149134.7000.1284.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rpurdie@rpsys.net \
    --cc=sakari.ailus@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox