From: Pavel Machek <pavel@ucw.cz>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-leds@vger.kernel.org, sakari.ailus@iki.fi
Subject: Re: [PATCH v1] leds: Clarify supported chips by LM355x driver
Date: Fri, 26 Jan 2018 22:05:06 +0100 [thread overview]
Message-ID: <20180126210506.GA7801@amd> (raw)
In-Reply-To: <1516967041.7000.1282.camel@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
On Fri 2018-01-26 13:44:01, Andy Shevchenko wrote:
> On Fri, 2018-01-26 at 11:25 +0100, Pavel Machek wrote:
> > On Fri 2018-01-26 09:38:28, Andy Shevchenko wrote:
> > > LM3555 is supported by AS3645A.
> > > Clarify this in Kconfig by referencing to AS3645A.
> > >
> > > No functional change.
>
> > > This option enables support for LEDs connected to LM355x.
> > > LM355x includes Torch, Flash and Indicator functions.
> > >
> > > + Note, LM3555 is driven by AS3645A.
> > > +
> >
> > I took a look at the driver. It seems to me lm355x only handles lm3554
> > and lm3556?
>
> Correct.
>
> > Perhaps Kconfig help should say that explicitely?
>
> It's in the title.
Aha.
Acked-by: Pavel Machek <pavel@ucw.cz>
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-01-26 21:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 7:38 [PATCH v1] leds: Clarify supported chips by LM355x driver Andy Shevchenko
2018-01-26 10:25 ` Pavel Machek
2018-01-26 11:44 ` Andy Shevchenko
2018-01-26 21:05 ` Pavel Machek [this message]
2018-01-26 21:32 ` Pavel Machek
2018-01-26 22:07 ` Sakari Ailus
2018-01-28 14:18 ` Andy Shevchenko
2018-01-26 20:39 ` Jacek Anaszewski
2018-01-28 14:30 ` Andy Shevchenko
2018-01-29 20:46 ` Jacek Anaszewski
2018-01-30 11:08 ` Andy Shevchenko
2018-01-30 20:04 ` Jacek Anaszewski
2018-02-01 20:26 ` [PATCH v2] " Pavel Machek
2018-02-01 21:33 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180126210506.GA7801@amd \
--to=pavel@ucw.cz \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox