From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Lee Jones <lee@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-renesas-soc@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, Pavel Machek <pavel@kernel.org>,
linux-leds <linux-leds@vger.kernel.org>
Subject: Re: [PATCH v3] ARM: dts: renesas: r9a06g032-rzn1d400-db: describe Debug LEDs
Date: Thu, 15 May 2025 21:53:59 +0200 [thread overview]
Message-ID: <1945f0d2-5e29-467b-8208-adf4e8560e8c@gmail.com> (raw)
In-Reply-To: <aCWlenAtx2uaQhcE@shikoro>
Hi Wolfram,
On 5/15/25 10:27, Wolfram Sang wrote:
> Hi all,
>
> thank you for providing all this input. I appreciate this a lot. And
> please excuse the slow response. I am currently at the EmbeddedRecipes
> conference which needed a bit of preparation on my side.
>
>> So the node would look like this, for the pca1 LED:
>>
>> led-1 {
>> function = "pca1";
>> color = <LED_COLOR_GREEN>;
>> default-state = "keep";
>> };
>
> This looks optimal to me, if this is acceptable. I totally understand
> the advantages and desire to unify LED naming. The main problem for me
> here is that the GPIO-driven LEDs have no 'device' part in the generic
Actually devicename section is expected mostly for LEDs that are somehow
associated with other devices. In most cases it can be skipped, see [0].
[0]
https://github.com/torvalds/linux/blob/master/Documentation/leds/leds-class.rst#led-device-naming
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2025-05-15 19:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250417093256.40390-2-wsa+renesas@sang-engineering.com>
2025-04-17 11:39 ` [PATCH v3] ARM: dts: renesas: r9a06g032-rzn1d400-db: describe Debug LEDs Geert Uytterhoeven
2025-05-08 7:56 ` Wolfram Sang
2025-05-08 13:49 ` Lee Jones
2025-05-10 12:43 ` Jacek Anaszewski
2025-05-12 7:13 ` Geert Uytterhoeven
2025-05-12 17:54 ` Jacek Anaszewski
2025-05-14 15:28 ` Lee Jones
2025-05-14 18:57 ` Jacek Anaszewski
2025-05-15 6:53 ` Lee Jones
2025-05-15 20:14 ` Jacek Anaszewski
2025-05-15 8:27 ` Wolfram Sang
2025-05-15 9:15 ` Lee Jones
2025-05-15 19:53 ` Jacek Anaszewski [this message]
2025-05-16 7:35 ` Alexander Dahl
2025-05-18 14:36 ` Jacek Anaszewski
2025-05-19 7:37 ` Alexander Dahl
2025-05-19 21:14 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1945f0d2-5e29-467b-8208-adf4e8560e8c@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox