From: Lee Jones <lee.jones@linaro.org>
To: Andreas Werner <andreas.werner@men.de>
Cc: Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, sameo@linux.intel.com,
wim@iguana.be, linux-watchdog@vger.kernel.org,
cooloney@gmail.com, rpurdie@rpsys.net,
linux-leds@vger.kernel.org, johannes.thumshirn@men.de,
thomas.schnuerer@men.de, wernerandy@gmx.de
Subject: Re: [PATCH 1/3] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver
Date: Tue, 20 May 2014 08:06:44 +0100 [thread overview]
Message-ID: <20140520070644.GB20874@lee--X1> (raw)
In-Reply-To: <20140520074748.GC398@awelinux>
> > > Not my call to make; depends on the mfd maintainer. I would not accept it, as I see it
> > > as unnecessary, adding complexity, and pointless. Sure, you can always find examples
> > > for everything somewhere in the kernel, but that doesn't make it better.
> >
> > I'm inclined to agree with Guenter, this patch is just noise.
>
> Ok no problem, i will fix it and resend the patch.
> For now I know it for the future :-)
>
> Any other comments about the patch series?
If you submit a v2, I'll re-review the bits you leave in.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-05-20 7:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 16:36 [PATCH 0/3] Introduce MEN 14F021P00 Board Management Controller driver set Andreas Werner
2014-05-16 16:37 ` [PATCH 1/3] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Andreas Werner
2014-05-17 15:47 ` Guenter Roeck
2014-05-19 12:43 ` Andreas Werner
2014-05-19 13:23 ` Guenter Roeck
2014-05-19 17:39 ` Lee Jones
2014-05-20 7:47 ` Andreas Werner
2014-05-20 7:06 ` Lee Jones [this message]
2014-05-16 16:37 ` [PATCH 2/3] drivers/watchdog/menf21bmc_wd: introduce MEN 14F021P00 BMC Watchdog driver Andreas Werner
2014-05-17 15:57 ` Guenter Roeck
2014-05-19 12:20 ` Andreas Werner
2014-05-16 16:37 ` [PATCH 3/3] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver Andreas Werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520070644.GB20874@lee--X1 \
--to=lee.jones@linaro.org \
--cc=andreas.werner@men.de \
--cc=cooloney@gmail.com \
--cc=johannes.thumshirn@men.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rpurdie@rpsys.net \
--cc=sameo@linux.intel.com \
--cc=thomas.schnuerer@men.de \
--cc=wernerandy@gmx.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox