From: "Marek Behún" <kabel@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
simon.guinot@sequanux.org, linux-leds@vger.kernel.org,
j.anaszewski@samsung.com
Subject: Re: [bug report] leds: ns2: Remove work queue
Date: Wed, 15 Dec 2021 22:04:41 +0100 [thread overview]
Message-ID: <20211215220441.2d83299a@thinkpad> (raw)
In-Reply-To: <20211215203955.GG28336@duo.ucw.cz>
On Wed, 15 Dec 2021 21:39:55 +0100
Pavel Machek <pavel@ucw.cz> wrote:
> Hi!
>
> > Hello LED devs,
> >
> > The patch c29e650b3af2: "leds: ns2: Remove work queue" from Nov 20,
> > 2015, leads to the following Smatch static checker warning:
> >
> > drivers/leds/leds-ns2.c:96 ns2_led_set_mode()
> > warn: sleeping in atomic context
>
> Yup, this looks wrong.
>
> Plus, the code is quite crazy.
>
> Not sure what the write_lock in that function is supposed to protect
> against. Perhaps it can be just removed?
>
> Hmm. led_set_mode uses custom interface for hardware accelerated
> LED. Ideally there's more fixing to be done there :-(.
The last time we discussed this, Simon said that he is willing to
convert once we have trigger offloading API. But we will also need
blkdev trigger. Time to review Ian Pilcher's last attempt at blkdev?
[RESEND PATCH v8 0/2] Introduce block device LED trigger
https://lore.kernel.org/linux-leds/20211119212733.286427-1-arequipeno@gmail.com/
Marek
next prev parent reply other threads:[~2021-12-15 21:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 13:52 [bug report] leds: ns2: Remove work queue Dan Carpenter
2021-12-15 20:39 ` Pavel Machek
2021-12-15 21:04 ` Marek Behún [this message]
2021-12-16 10:30 ` Simon Guinot
2021-12-20 17:00 ` Ian Pilcher
2021-12-16 10:28 ` Simon Guinot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211215220441.2d83299a@thinkpad \
--to=kabel@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=j.anaszewski@samsung.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=simon.guinot@sequanux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox