From: Simon Guinot <simon.guinot@sequanux.org>
To: "Marek Behún" <kabel@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>,
Dan Carpenter <dan.carpenter@oracle.com>,
linux-leds@vger.kernel.org, j.anaszewski@samsung.com
Subject: Re: [bug report] leds: ns2: Remove work queue
Date: Thu, 16 Dec 2021 11:30:59 +0100 [thread overview]
Message-ID: <YbsVY7Xqa6k1Plba@kw.sim.vm.gnt> (raw)
In-Reply-To: <20211215220441.2d83299a@thinkpad>
[-- Attachment #1: Type: text/plain, Size: 1183 bytes --]
On Wed, Dec 15, 2021 at 10:04:41PM +0100, Marek Behún wrote:
> On Wed, 15 Dec 2021 21:39:55 +0100
> Pavel Machek <pavel@ucw.cz> wrote:
>
> > Hi!
> >
> > > Hello LED devs,
> > >
> > > The patch c29e650b3af2: "leds: ns2: Remove work queue" from Nov 20,
> > > 2015, leads to the following Smatch static checker warning:
> > >
> > > drivers/leds/leds-ns2.c:96 ns2_led_set_mode()
> > > warn: sleeping in atomic context
> >
> > Yup, this looks wrong.
> >
> > Plus, the code is quite crazy.
> >
> > Not sure what the write_lock in that function is supposed to protect
> > against. Perhaps it can be just removed?
> >
> > Hmm. led_set_mode uses custom interface for hardware accelerated
> > LED. Ideally there's more fixing to be done there :-(.
>
> The last time we discussed this, Simon said that he is willing to
> convert once we have trigger offloading API. But we will also need
> blkdev trigger. Time to review Ian Pilcher's last attempt at blkdev?
> [RESEND PATCH v8 0/2] Introduce block device LED trigger
> https://lore.kernel.org/linux-leds/20211119212733.286427-1-arequipeno@gmail.com/
Hi Marek,
I kind of remembering that :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-12-16 10:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 13:52 [bug report] leds: ns2: Remove work queue Dan Carpenter
2021-12-15 20:39 ` Pavel Machek
2021-12-15 21:04 ` Marek Behún
2021-12-16 10:30 ` Simon Guinot [this message]
2021-12-20 17:00 ` Ian Pilcher
2021-12-16 10:28 ` Simon Guinot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbsVY7Xqa6k1Plba@kw.sim.vm.gnt \
--to=simon.guinot@sequanux.org \
--cc=dan.carpenter@oracle.com \
--cc=j.anaszewski@samsung.com \
--cc=kabel@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox