Linux LED subsystem development
 help / color / mirror / Atom feed
* [PATCH] leds: clevo-mail: fix Kconfig "its" grammar
@ 2022-07-15  1:59 Randy Dunlap
  2022-07-17 10:22 ` Pavel Machek
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2022-07-15  1:59 UTC (permalink / raw)
  To: linux-kernel; +Cc: Randy Dunlap, Pavel Machek, Lee Jones, linux-leds

Use the possessive "its" instead of the contraction "it's"
where appropriate.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: linux-leds@vger.kernel.org
---
 drivers/leds/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -456,7 +456,7 @@ config LEDS_CLEVO_MAIL
 
 	  The driver supports two kinds of interface: using ledtrig-timer
 	  or through /sys/class/leds/clevo::mail/brightness. As this LED
-	  cannot change it's brightness it blinks instead. The brightness
+	  cannot change its brightness it blinks instead. The brightness
 	  value 0 means off, 1..127 means blink at 0.5Hz and 128..255 means
 	  blink at 1Hz.
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] leds: clevo-mail: fix Kconfig "its" grammar
  2022-07-15  1:59 [PATCH] leds: clevo-mail: fix Kconfig "its" grammar Randy Dunlap
@ 2022-07-17 10:22 ` Pavel Machek
  0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2022-07-17 10:22 UTC (permalink / raw)
  To: Randy Dunlap, nm127; +Cc: linux-kernel, Lee Jones, linux-leds

[-- Attachment #1: Type: text/plain, Size: 1726 bytes --]

On Thu 2022-07-14 18:59:48, Randy Dunlap wrote:
> Use the possessive "its" instead of the contraction "it's"
> where appropriate.

Thank you, applied.

Hu. Hmm. Wow.

What is that? Kconfig describes very non-standard kernel interface,
and has several other typos in the it. I can fix the typos; but is
there someone still using this who would be willing to fix it?

Best regards,
								Pavel
> @@ -456,7 +456,7 @@ config LEDS_CLEVO_MAIL
>  
>  	  The driver supports two kinds of interface: using ledtrig-timer
>  	  or through /sys/class/leds/clevo::mail/brightness. As this LED
> -	  cannot change it's brightness it blinks instead. The brightness
> +	  cannot change its brightness it blinks instead. The brightness
>  	  value 0 means off, 1..127 means blink at 0.5Hz and 128..255 means
>  	  blink at 1Hz.
>  

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index acd4f754c919..eaba0a8347fa 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -447,12 +447,12 @@ config LEDS_LP8860
 
 config LEDS_CLEVO_MAIL
 	tristate "Mail LED on Clevo notebook"
-	depends on LEDS_CLASS
+	depends on LEDS_CLASS && BROKEN
 	depends on X86 && SERIO_I8042 && DMI
 	help
 	  This driver makes the mail LED accessible from userspace
-	  programs through the leds subsystem. This LED have three
-	  known mode: off, blink at 0.5Hz and blink at 1Hz.
+	  programs through the LEDs subsystem. This LED has three
+	  known modes: off, blink at 0.5Hz and blink at 1Hz.
 
 	  The driver supports two kinds of interface: using ledtrig-timer
 	  or through /sys/class/leds/clevo::mail/brightness. As this LED

-- 
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-07-17 10:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-15  1:59 [PATCH] leds: clevo-mail: fix Kconfig "its" grammar Randy Dunlap
2022-07-17 10:22 ` Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox