Re: [PATCH v2 0/1] Introduce userspace LED triggers driver

[Lee Jones <lee@kernel.org>]

On Tue, 11 Mar 2025, Craig McQueen wrote:

> I've done some significant rework since my original submission of this.
> 
> * Moved and renamed driver to drivers/leds/trigger/ledtrig-user.c, 
> following kernel arrangement of trigger drivers.
> But note the char device name and uapi header file are still named 
> 'uledtriggers'.
> * Fixed a mutex reentrancy issue with the 'activate' function.
> * Code refactoring and add comments.
> * Add new documentation page to index.
> 
> Craig McQueen (1):
>   leds: Introduce userspace LED triggers driver
> 
>  Documentation/leds/index.rst        |   1 +
>  Documentation/leds/ledtrig-user.rst |  36 +++
>  drivers/leds/trigger/Kconfig        |  10 +
>  drivers/leds/trigger/Makefile       |   1 +
>  drivers/leds/trigger/ledtrig-user.c | 348 ++++++++++++++++++++++++++++
>  include/uapi/linux/uledtriggers.h   | 123 ++++++++++
>  6 files changed, 519 insertions(+)
>  create mode 100644 Documentation/leds/ledtrig-user.rst
>  create mode 100644 drivers/leds/trigger/ledtrig-user.c
>  create mode 100644 include/uapi/linux/uledtriggers.h

This is a fairly large inclusion.

I'm going to let this sit on the LEDs list for a few more weeks.

You should also consider always Cc:ing LKML, since a lot of useful
reviewers don't subscribe to all of the little subsystem lists.

-- 
Lee Jones [李琼斯]