Re: [PATCH v2 1/1] leds: Introduce userspace LED triggers driver

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]

Hi!

> This driver creates a userspace LED triggers driver similar to
> uleds and uinput.
> 
> New LED triggers are created by opening /dev/uledtriggers and writing
> a uledtriggers_user_dev struct. A new LED trigger is registered with the
> name given in the struct.
> 
> After the initial setup, writing an int value will set the trigger's
> brightness, equivalent to calling led_trigger_event().
> 
> Alternatively, there are ioctls for setup, changing trigger brightness,
> or doing blinking.
> 
> Closing the file handle to /dev/uledtriggers will remove the LED
> trigger.

Would you explain some usecases where this is useful?

Userspace can already control the leds using /sys/class/leds...


> +++ b/include/uapi/linux/uledtriggers.h
> +/*
> + * Brightness levels for writes of int values, or for use with ULEDTRIGGERS_IOC_EVENT.
> + * These correspond to Linux kernel internal enum led_brightness in linux/leds.h.
> + */
> +enum uledtriggers_brightness {
> +	ULEDTRIGGERS_OFF		= 0,
> +	ULEDTRIGGERS_ON			= 1,
> +	ULEDTRIGGERS_HALF		= 127,
> +	ULEDTRIGGERS_FULL		= 255,
> +};

We are trying to get rid of brightness half, etc. Userspace can
already make leds blink and use oneshot.

NAK.

Best regards,

								Pavel
-- 
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, and Musk!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]