* Re: [RFC PATCH 2/3] platform/x86: Add Uniwill laptop driver [not found] ` <41de4cd4-2a27-4b14-a1c0-e336a3cec317@tuxedocomputers.com> @ 2025-06-17 21:52 ` Armin Wolf 2025-06-19 9:47 ` Lee Jones 0 siblings, 1 reply; 6+ messages in thread From: Armin Wolf @ 2025-06-17 21:52 UTC (permalink / raw) To: Werner Sembach, ilpo.jarvinen, hdegoede, chumuzero, corbet, cs, ggo Cc: linux-doc, linux-kernel, platform-driver-x86, linux-leds Am 16.06.25 um 14:46 schrieb Werner Sembach: > Hi, small additon > > Am 15.06.25 um 19:59 schrieb Armin Wolf: >> + functionality. >> + >> +What: >> /sys/bus/wmi/devices/ABBC0F6F-8EA1-11D1-00A0-C90629100000[-X]/rainbow_animation >> +Date: Juni 2025 >> +KernelVersion: 6.17 >> +Contact: Armin Wolf <W_Armin@gmx.de> >> +Description: >> + Forces the integrated lightbar to display a rainbow >> animation when the machine >> + is not suspended. Writing "enable"/"disable" into this file >> enables/disables >> + this functionality. >> + >> + Reading this file returns the current status of the rainbow >> animation functionality. >> + >> +What: >> /sys/bus/wmi/devices/ABBC0F6F-8EA1-11D1-00A0-C90629100000[-X]/breathing_in_suspend >> +Date: Juni 2025 >> +KernelVersion: 6.17 >> +Contact: Armin Wolf <W_Armin@gmx.de> >> +Description: >> + Causes the integrated lightbar to display a breathing >> animation when the machine >> + has been suspended and is running on AC power. Writing >> "enable"/"disable" into >> + this file enables/disables this functionality. >> + >> + Reading this file returns the current status of the >> breathing animation >> + functionality. > > maybe this would be better under the /sys/class/leds/*/ tree if possible I CCed the LED mailing list so that they can give us advice on which location is the preferred one for new drivers. Thanks, Armin Wolf ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 2/3] platform/x86: Add Uniwill laptop driver 2025-06-17 21:52 ` [RFC PATCH 2/3] platform/x86: Add Uniwill laptop driver Armin Wolf @ 2025-06-19 9:47 ` Lee Jones 2025-06-19 12:30 ` Hans de Goede 0 siblings, 1 reply; 6+ messages in thread From: Lee Jones @ 2025-06-19 9:47 UTC (permalink / raw) To: Armin Wolf Cc: Werner Sembach, ilpo.jarvinen, hdegoede, chumuzero, corbet, cs, ggo, linux-doc, linux-kernel, platform-driver-x86, linux-leds On Tue, 17 Jun 2025, Armin Wolf wrote: > Am 16.06.25 um 14:46 schrieb Werner Sembach: > > > Hi, small additon > > > > Am 15.06.25 um 19:59 schrieb Armin Wolf: > > > + functionality. > > > + > > > +What: /sys/bus/wmi/devices/ABBC0F6F-8EA1-11D1-00A0-C90629100000[-X]/rainbow_animation > > > +Date: Juni 2025 > > > +KernelVersion: 6.17 > > > +Contact: Armin Wolf <W_Armin@gmx.de> > > > +Description: > > > + Forces the integrated lightbar to display a rainbow > > > animation when the machine > > > + is not suspended. Writing "enable"/"disable" into this file > > > enables/disables > > > + this functionality. > > > + > > > + Reading this file returns the current status of the rainbow > > > animation functionality. > > > + > > > +What: /sys/bus/wmi/devices/ABBC0F6F-8EA1-11D1-00A0-C90629100000[-X]/breathing_in_suspend > > > +Date: Juni 2025 > > > +KernelVersion: 6.17 > > > +Contact: Armin Wolf <W_Armin@gmx.de> > > > +Description: > > > + Causes the integrated lightbar to display a breathing > > > animation when the machine > > > + has been suspended and is running on AC power. Writing > > > "enable"/"disable" into > > > + this file enables/disables this functionality. > > > + > > > + Reading this file returns the current status of the > > > breathing animation > > > + functionality. > > > > maybe this would be better under the /sys/class/leds/*/ tree if possible > > I CCed the LED mailing list so that they can give us advice on which location is the preferred one for new drivers. No need to involve the LED subsystem for a hardware function controlled by a single register value just because the interface involves an LED. -- Lee Jones [李琼斯] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 2/3] platform/x86: Add Uniwill laptop driver 2025-06-19 9:47 ` Lee Jones @ 2025-06-19 12:30 ` Hans de Goede 2025-06-19 15:17 ` Lee Jones 0 siblings, 1 reply; 6+ messages in thread From: Hans de Goede @ 2025-06-19 12:30 UTC (permalink / raw) To: Lee Jones, Armin Wolf Cc: Werner Sembach, ilpo.jarvinen, hdegoede, chumuzero, corbet, cs, ggo, linux-doc, linux-kernel, platform-driver-x86, linux-leds Hi Lee, On 19-Jun-25 11:47 AM, Lee Jones wrote: > On Tue, 17 Jun 2025, Armin Wolf wrote: > >> Am 16.06.25 um 14:46 schrieb Werner Sembach: >> >>> Hi, small additon >>> >>> Am 15.06.25 um 19:59 schrieb Armin Wolf: >>>> + functionality. >>>> + >>>> +What: /sys/bus/wmi/devices/ABBC0F6F-8EA1-11D1-00A0-C90629100000[-X]/rainbow_animation >>>> +Date: Juni 2025 >>>> +KernelVersion: 6.17 >>>> +Contact: Armin Wolf <W_Armin@gmx.de> >>>> +Description: >>>> + Forces the integrated lightbar to display a rainbow >>>> animation when the machine >>>> + is not suspended. Writing "enable"/"disable" into this file >>>> enables/disables >>>> + this functionality. >>>> + >>>> + Reading this file returns the current status of the rainbow >>>> animation functionality. >>>> + >>>> +What: /sys/bus/wmi/devices/ABBC0F6F-8EA1-11D1-00A0-C90629100000[-X]/breathing_in_suspend >>>> +Date: Juni 2025 >>>> +KernelVersion: 6.17 >>>> +Contact: Armin Wolf <W_Armin@gmx.de> >>>> +Description: >>>> + Causes the integrated lightbar to display a breathing >>>> animation when the machine >>>> + has been suspended and is running on AC power. Writing >>>> "enable"/"disable" into >>>> + this file enables/disables this functionality. >>>> + >>>> + Reading this file returns the current status of the >>>> breathing animation >>>> + functionality. >>> >>> maybe this would be better under the /sys/class/leds/*/ tree if possible >> >> I CCed the LED mailing list so that they can give us advice on which location is the preferred one for new drivers. > > No need to involve the LED subsystem for a hardware function controlled > by a single register value just because the interface involves an LED. Lee, the question here is where put the sysfs attribute to put the lightbar in breathing mode e.g. which of these 2 should be used? : 1. /sys/bus/wmi/devices/ABBC0F6F-8EA1-11D1-00A0-C90629100000[-X]/breathing_in_suspend 2. /sys/class/leds/uniwill-lightbar/breathing_in_suspend I think this is a fair question and since 2. involves the LED class userspace API I also think that asking for the LED maintainers input is reasonable. FWIW I'm not sure myself. 2. is the more logical place / path. But 2. adds a custom sysfs attr the LED class device. Whereas 1. adds a custom sysfs attr in a place where these are more or less expected. Regards, Hans ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 2/3] platform/x86: Add Uniwill laptop driver 2025-06-19 12:30 ` Hans de Goede @ 2025-06-19 15:17 ` Lee Jones 2025-06-19 20:03 ` Hans de Goede 0 siblings, 1 reply; 6+ messages in thread From: Lee Jones @ 2025-06-19 15:17 UTC (permalink / raw) To: Hans de Goede Cc: Armin Wolf, Werner Sembach, ilpo.jarvinen, hdegoede, chumuzero, corbet, cs, ggo, linux-doc, linux-kernel, platform-driver-x86, linux-leds On Thu, 19 Jun 2025, Hans de Goede wrote: > Hi Lee, > > On 19-Jun-25 11:47 AM, Lee Jones wrote: > > On Tue, 17 Jun 2025, Armin Wolf wrote: > > > >> Am 16.06.25 um 14:46 schrieb Werner Sembach: > >> > >>> Hi, small additon > >>> > >>> Am 15.06.25 um 19:59 schrieb Armin Wolf: > >>>> + functionality. > >>>> + > >>>> +What: /sys/bus/wmi/devices/ABBC0F6F-8EA1-11D1-00A0-C90629100000[-X]/rainbow_animation > >>>> +Date: Juni 2025 > >>>> +KernelVersion: 6.17 > >>>> +Contact: Armin Wolf <W_Armin@gmx.de> > >>>> +Description: > >>>> + Forces the integrated lightbar to display a rainbow > >>>> animation when the machine > >>>> + is not suspended. Writing "enable"/"disable" into this file > >>>> enables/disables > >>>> + this functionality. > >>>> + > >>>> + Reading this file returns the current status of the rainbow > >>>> animation functionality. > >>>> + > >>>> +What: /sys/bus/wmi/devices/ABBC0F6F-8EA1-11D1-00A0-C90629100000[-X]/breathing_in_suspend > >>>> +Date: Juni 2025 > >>>> +KernelVersion: 6.17 > >>>> +Contact: Armin Wolf <W_Armin@gmx.de> > >>>> +Description: > >>>> + Causes the integrated lightbar to display a breathing > >>>> animation when the machine > >>>> + has been suspended and is running on AC power. Writing > >>>> "enable"/"disable" into > >>>> + this file enables/disables this functionality. > >>>> + > >>>> + Reading this file returns the current status of the > >>>> breathing animation > >>>> + functionality. > >>> > >>> maybe this would be better under the /sys/class/leds/*/ tree if possible > >> > >> I CCed the LED mailing list so that they can give us advice on which location is the preferred one for new drivers. > > > > No need to involve the LED subsystem for a hardware function controlled > > by a single register value just because the interface involves an LED. > > Lee, the question here is where put the sysfs attribute to put the lightbar > in breathing mode e.g. which of these 2 should be used? : > > 1. /sys/bus/wmi/devices/ABBC0F6F-8EA1-11D1-00A0-C90629100000[-X]/breathing_in_suspend > 2. /sys/class/leds/uniwill-lightbar/breathing_in_suspend > > I think this is a fair question and since 2. involves the LED class userspace > API I also think that asking for the LED maintainers input is reasonable. > > FWIW I'm not sure myself. 2. is the more logical place / path. But 2. adds > a custom sysfs attr the LED class device. Whereas 1. adds a custom sysfs attr > in a place where these are more or less expected. Right. It was a reasonable question. Did I imply otherwise? If it wasn't clear, my vote (this is not a dictatorship) is for 1. -- Lee Jones [李琼斯] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 2/3] platform/x86: Add Uniwill laptop driver 2025-06-19 15:17 ` Lee Jones @ 2025-06-19 20:03 ` Hans de Goede 2025-06-22 19:19 ` Armin Wolf 0 siblings, 1 reply; 6+ messages in thread From: Hans de Goede @ 2025-06-19 20:03 UTC (permalink / raw) To: Lee Jones Cc: Armin Wolf, Werner Sembach, ilpo.jarvinen, chumuzero, corbet, cs, ggo, linux-doc, linux-kernel, platform-driver-x86, linux-leds Hi Lee, On 19-Jun-25 5:17 PM, Lee Jones wrote: > On Thu, 19 Jun 2025, Hans de Goede wrote: > >> Hi Lee, >> >> On 19-Jun-25 11:47 AM, Lee Jones wrote: >>> On Tue, 17 Jun 2025, Armin Wolf wrote: >>> >>>> Am 16.06.25 um 14:46 schrieb Werner Sembach: >>>> >>>>> Hi, small additon >>>>> >>>>> Am 15.06.25 um 19:59 schrieb Armin Wolf: >>>>>> + functionality. >>>>>> + >>>>>> +What: /sys/bus/wmi/devices/ABBC0F6F-8EA1-11D1-00A0-C90629100000[-X]/rainbow_animation >>>>>> +Date: Juni 2025 >>>>>> +KernelVersion: 6.17 >>>>>> +Contact: Armin Wolf <W_Armin@gmx.de> >>>>>> +Description: >>>>>> + Forces the integrated lightbar to display a rainbow >>>>>> animation when the machine >>>>>> + is not suspended. Writing "enable"/"disable" into this file >>>>>> enables/disables >>>>>> + this functionality. >>>>>> + >>>>>> + Reading this file returns the current status of the rainbow >>>>>> animation functionality. >>>>>> + >>>>>> +What: /sys/bus/wmi/devices/ABBC0F6F-8EA1-11D1-00A0-C90629100000[-X]/breathing_in_suspend >>>>>> +Date: Juni 2025 >>>>>> +KernelVersion: 6.17 >>>>>> +Contact: Armin Wolf <W_Armin@gmx.de> >>>>>> +Description: >>>>>> + Causes the integrated lightbar to display a breathing >>>>>> animation when the machine >>>>>> + has been suspended and is running on AC power. Writing >>>>>> "enable"/"disable" into >>>>>> + this file enables/disables this functionality. >>>>>> + >>>>>> + Reading this file returns the current status of the >>>>>> breathing animation >>>>>> + functionality. >>>>> >>>>> maybe this would be better under the /sys/class/leds/*/ tree if possible >>>> >>>> I CCed the LED mailing list so that they can give us advice on which location is the preferred one for new drivers. >>> >>> No need to involve the LED subsystem for a hardware function controlled >>> by a single register value just because the interface involves an LED. >> >> Lee, the question here is where put the sysfs attribute to put the lightbar >> in breathing mode e.g. which of these 2 should be used? : >> >> 1. /sys/bus/wmi/devices/ABBC0F6F-8EA1-11D1-00A0-C90629100000[-X]/breathing_in_suspend >> 2. /sys/class/leds/uniwill-lightbar/breathing_in_suspend >> >> I think this is a fair question and since 2. involves the LED class userspace >> API I also think that asking for the LED maintainers input is reasonable. >> >> FWIW I'm not sure myself. 2. is the more logical place / path. But 2. adds >> a custom sysfs attr the LED class device. Whereas 1. adds a custom sysfs attr >> in a place where these are more or less expected. > > Right. It was a reasonable question. Did I imply otherwise? Sorry, my bad, I interpreted your "No need to involve the LED subsystem for a hardware function ..." remark as meaning that you did not understand why you were Cc-ed. I now realize that you meant that you believe the control for this does not need to be under /sys/class/leds/ > If it wasn't clear, my vote (this is not a dictatorship) is for 1. Ok, 1. works for me and that is what the patch is already doing, so lets keep it as as. Regards, Hans ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 2/3] platform/x86: Add Uniwill laptop driver 2025-06-19 20:03 ` Hans de Goede @ 2025-06-22 19:19 ` Armin Wolf 0 siblings, 0 replies; 6+ messages in thread From: Armin Wolf @ 2025-06-22 19:19 UTC (permalink / raw) To: Hans de Goede, Lee Jones Cc: Werner Sembach, ilpo.jarvinen, chumuzero, corbet, cs, ggo, linux-doc, linux-kernel, platform-driver-x86, linux-leds Am 19.06.25 um 22:03 schrieb Hans de Goede: > Hi Lee, > > On 19-Jun-25 5:17 PM, Lee Jones wrote: >> On Thu, 19 Jun 2025, Hans de Goede wrote: >> >>> Hi Lee, >>> >>> On 19-Jun-25 11:47 AM, Lee Jones wrote: >>>> On Tue, 17 Jun 2025, Armin Wolf wrote: >>>> >>>>> Am 16.06.25 um 14:46 schrieb Werner Sembach: >>>>> >>>>>> Hi, small additon >>>>>> >>>>>> Am 15.06.25 um 19:59 schrieb Armin Wolf: >>>>>>> + functionality. >>>>>>> + >>>>>>> +What: /sys/bus/wmi/devices/ABBC0F6F-8EA1-11D1-00A0-C90629100000[-X]/rainbow_animation >>>>>>> +Date: Juni 2025 >>>>>>> +KernelVersion: 6.17 >>>>>>> +Contact: Armin Wolf <W_Armin@gmx.de> >>>>>>> +Description: >>>>>>> + Forces the integrated lightbar to display a rainbow >>>>>>> animation when the machine >>>>>>> + is not suspended. Writing "enable"/"disable" into this file >>>>>>> enables/disables >>>>>>> + this functionality. >>>>>>> + >>>>>>> + Reading this file returns the current status of the rainbow >>>>>>> animation functionality. >>>>>>> + >>>>>>> +What: /sys/bus/wmi/devices/ABBC0F6F-8EA1-11D1-00A0-C90629100000[-X]/breathing_in_suspend >>>>>>> +Date: Juni 2025 >>>>>>> +KernelVersion: 6.17 >>>>>>> +Contact: Armin Wolf <W_Armin@gmx.de> >>>>>>> +Description: >>>>>>> + Causes the integrated lightbar to display a breathing >>>>>>> animation when the machine >>>>>>> + has been suspended and is running on AC power. Writing >>>>>>> "enable"/"disable" into >>>>>>> + this file enables/disables this functionality. >>>>>>> + >>>>>>> + Reading this file returns the current status of the >>>>>>> breathing animation >>>>>>> + functionality. >>>>>> maybe this would be better under the /sys/class/leds/*/ tree if possible >>>>> I CCed the LED mailing list so that they can give us advice on which location is the preferred one for new drivers. >>>> No need to involve the LED subsystem for a hardware function controlled >>>> by a single register value just because the interface involves an LED. >>> Lee, the question here is where put the sysfs attribute to put the lightbar >>> in breathing mode e.g. which of these 2 should be used? : >>> >>> 1. /sys/bus/wmi/devices/ABBC0F6F-8EA1-11D1-00A0-C90629100000[-X]/breathing_in_suspend >>> 2. /sys/class/leds/uniwill-lightbar/breathing_in_suspend >>> >>> I think this is a fair question and since 2. involves the LED class userspace >>> API I also think that asking for the LED maintainers input is reasonable. >>> >>> FWIW I'm not sure myself. 2. is the more logical place / path. But 2. adds >>> a custom sysfs attr the LED class device. Whereas 1. adds a custom sysfs attr >>> in a place where these are more or less expected. >> Right. It was a reasonable question. Did I imply otherwise? > Sorry, my bad, I interpreted your "No need to involve the LED > subsystem for a hardware function ..." remark as meaning that > you did not understand why you were Cc-ed. > > I now realize that you meant that you believe the control for > this does not need to be under /sys/class/leds/ > >> If it wasn't clear, my vote (this is not a dictatorship) is for 1. > Ok, 1. works for me and that is what the patch is already doing, > so lets keep it as as. > > Regards, > > Hans Fine with me. Armin Wolf ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-06-22 19:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250615175957.9781-1-W_Armin@gmx.de>
[not found] ` <20250615175957.9781-3-W_Armin@gmx.de>
[not found] ` <41de4cd4-2a27-4b14-a1c0-e336a3cec317@tuxedocomputers.com>
2025-06-17 21:52 ` [RFC PATCH 2/3] platform/x86: Add Uniwill laptop driver Armin Wolf
2025-06-19 9:47 ` Lee Jones
2025-06-19 12:30 ` Hans de Goede
2025-06-19 15:17 ` Lee Jones
2025-06-19 20:03 ` Hans de Goede
2025-06-22 19:19 ` Armin Wolf
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox