[lee-leds:for-leds-next 12/17] drivers/leds/rgb/leds-lp5860-core.c:119 lp5860_iterate_subleds() warn: passing zero to 'dev_err_probe'

[lee-leds:for-leds-next 12/17] drivers/leds/rgb/leds-lp5860-core.c:119 lp5860_iterate_subleds() warn: passing zero to 'dev_err_probe'

[Dan Carpenter]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next
head:   25025253476a64c186592d952c27f24bc3490e42
commit: 3daf2c4ef82b30d4cb017508f6857438ca44da41 [12/17] leds: Add support for TI LP5860 LED driver chip
config: x86_64-randconfig-161-20260521 (https://download.01.org/0day-ci/archive/20260521/202605210624.3gcr3prk-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
smatch: v0.5.0-9185-gbcc58b9c

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202605210624.3gcr3prk-lkp@intel.com/

smatch warnings:
drivers/leds/rgb/leds-lp5860-core.c:119 lp5860_iterate_subleds() warn: passing zero to 'dev_err_probe'

vim +/dev_err_probe +119 drivers/leds/rgb/leds-lp5860-core.c

3daf2c4ef82b30d Steffen Trumtrar 2026-05-05   97  static int lp5860_iterate_subleds(struct lp5860_led *led, struct led_init_data *init_data)
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05   98  {
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05   99  	struct fwnode_handle *led_node = NULL;
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  100  	struct fwnode_handle *multi_led = init_data->fwnode;
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  101  	int subled = 0;
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  102  
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  103  	fwnode_for_each_child_node(multi_led, led_node) {
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  104  		u32 channel;
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  105  		u32 color_index;
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  106  		int ret;
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  107  
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  108  		ret = fwnode_property_read_u32(led_node, "color", &color_index);
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  109  		if (ret) {
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  110  			dev_err_probe(led->chip->dev, ret,
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  111  				      "%pfwP: Cannot read 'color' property. Skipping.\n", led_node);
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  112  			fwnode_handle_put(led_node);
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  113  			return ret;
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  114  		}
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  115  
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  116  		ret = fwnode_property_read_u32(led_node, "reg", &channel);
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  117  		if (ret < 0 || channel > LP5860_MAX_LED) {
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  118  			dev_err_probe(led->chip->dev, ret,
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05 @119  				      "%pfwP: 'reg' property is missing. Skipping.\n", led_node);
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  120  			fwnode_handle_put(led_node);
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  121  			return ret;

Need to set an error code if channel > LP5860_MAX_LED.

3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  122  		}
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  123  
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  124  		led->mc_cdev.subled_info[subled].color_index = color_index;
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  125  		led->mc_cdev.subled_info[subled].channel = channel;
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  126  		ret = lp5860_led_init(led, init_data->fwnode, channel);
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  127  		if (ret) {
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  128  			dev_err_probe(led->chip->dev, ret,
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  129  				      "%pfwP: Failed to init LED\n", led_node);
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  130  			fwnode_handle_put(led_node);
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  131  			return ret;
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  132  		}
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  133  
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  134  		subled++;
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  135  	}
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  136  
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  137  	return 0;
3daf2c4ef82b30d Steffen Trumtrar 2026-05-05  138  }

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki