From: Arnd Bergmann <arnd@kernel.org>
To: Nam Tran <trannamatk@gmail.com>, Lee Jones <lee@kernel.org>,
Pavel Machek <pavel@kernel.org>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] leds: fix CONFIG_OF dependency for LEDS_LP5860_CORE
Date: Tue, 26 May 2026 12:37:32 +0200 [thread overview]
Message-ID: <20260526103738.3389272-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
Building LEDS_LP5860_SPI wihtout CONFIG_OF leads to a build time warning:
WARNING: unmet direct dependencies detected for LEDS_LP5860_CORE
Depends on [n]: NEW_LEDS [=y] && LEDS_CLASS_MULTICOLOR [=y] && LEDS_CLASS [=y] && OF [=n]
Selected by [y]:
- LEDS_LP5860_SPI [=y] && NEW_LEDS [=y] && LEDS_CLASS_MULTICOLOR [=y] && SPI [=y]
Address this by adding the same dependency here as well.
Fixes: 3daf2c4ef82b ("leds: Add support for TI LP5860 LED driver chip")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Another option would be to change the 'select LEDS_LP5860_CORE' to
a 'depends on'.
---
drivers/leds/rgb/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig
index 9a4ba6531cf8..b582ba2363af 100644
--- a/drivers/leds/rgb/Kconfig
+++ b/drivers/leds/rgb/Kconfig
@@ -56,6 +56,7 @@ config LEDS_LP5860_CORE
config LEDS_LP5860_SPI
tristate "LED Support for TI LP5860 SPI LED driver chip"
depends on SPI
+ depends on OF
select LEDS_LP5860_CORE
help
If you say yes here you get support for the Texas Instruments
--
2.39.5
next reply other threads:[~2026-05-26 10:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 10:37 Arnd Bergmann [this message]
2026-06-04 16:34 ` (subset) [PATCH] leds: fix CONFIG_OF dependency for LEDS_LP5860_CORE Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260526103738.3389272-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=s.trumtrar@pengutronix.de \
--cc=trannamatk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox