* [PATCH] leds: fix CONFIG_OF dependency for LEDS_LP5860_CORE
@ 2026-05-26 10:37 Arnd Bergmann
2026-06-04 16:34 ` (subset) " Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2026-05-26 10:37 UTC (permalink / raw)
To: Nam Tran, Lee Jones, Pavel Machek, Steffen Trumtrar
Cc: Arnd Bergmann, linux-leds, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Building LEDS_LP5860_SPI wihtout CONFIG_OF leads to a build time warning:
WARNING: unmet direct dependencies detected for LEDS_LP5860_CORE
Depends on [n]: NEW_LEDS [=y] && LEDS_CLASS_MULTICOLOR [=y] && LEDS_CLASS [=y] && OF [=n]
Selected by [y]:
- LEDS_LP5860_SPI [=y] && NEW_LEDS [=y] && LEDS_CLASS_MULTICOLOR [=y] && SPI [=y]
Address this by adding the same dependency here as well.
Fixes: 3daf2c4ef82b ("leds: Add support for TI LP5860 LED driver chip")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Another option would be to change the 'select LEDS_LP5860_CORE' to
a 'depends on'.
---
drivers/leds/rgb/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig
index 9a4ba6531cf8..b582ba2363af 100644
--- a/drivers/leds/rgb/Kconfig
+++ b/drivers/leds/rgb/Kconfig
@@ -56,6 +56,7 @@ config LEDS_LP5860_CORE
config LEDS_LP5860_SPI
tristate "LED Support for TI LP5860 SPI LED driver chip"
depends on SPI
+ depends on OF
select LEDS_LP5860_CORE
help
If you say yes here you get support for the Texas Instruments
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: (subset) [PATCH] leds: fix CONFIG_OF dependency for LEDS_LP5860_CORE
2026-05-26 10:37 [PATCH] leds: fix CONFIG_OF dependency for LEDS_LP5860_CORE Arnd Bergmann
@ 2026-06-04 16:34 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2026-06-04 16:34 UTC (permalink / raw)
To: Nam Tran, Lee Jones, Pavel Machek, Steffen Trumtrar,
Arnd Bergmann
Cc: Arnd Bergmann, linux-leds, linux-kernel
On Tue, 26 May 2026 12:37:32 +0200, Arnd Bergmann wrote:
> Building LEDS_LP5860_SPI wihtout CONFIG_OF leads to a build time warning:
>
> WARNING: unmet direct dependencies detected for LEDS_LP5860_CORE
> Depends on [n]: NEW_LEDS [=y] && LEDS_CLASS_MULTICOLOR [=y] && LEDS_CLASS [=y] && OF [=n]
> Selected by [y]:
> - LEDS_LP5860_SPI [=y] && NEW_LEDS [=y] && LEDS_CLASS_MULTICOLOR [=y] && SPI [=y]
>
> [...]
Applied, thanks!
[1/1] leds: fix CONFIG_OF dependency for LEDS_LP5860_CORE
commit: a2263676302a4eec40af93b3829f1d3d5aade93c
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-04 16:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-26 10:37 [PATCH] leds: fix CONFIG_OF dependency for LEDS_LP5860_CORE Arnd Bergmann
2026-06-04 16:34 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox