From: sashiko-bot@kernel.org
To: "Andreas Kemnade" <andreas@kemnade.info>
Cc: lee@kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v3] leds: is31fl319x: modernize registration
Date: Tue, 04 Aug 2026 13:55:14 +0000 [thread overview]
Message-ID: <20260804135515.5DBFC1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260804-led-modern-v3-1-297720eec19f@kemnade.info>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message description starts with a lowercase letter, which violates the LED subsystem guidelines.
--
--- Patch [1]: [PATCH v3] leds: is31fl319x: modernize registration ---
commit 8ca9b33466bf8fe661e87d3758c14a3394d87a31
Author: Andreas Kemnade <andreas@kemnade.info>
leds: is31fl319x: modernize registration
This commit updates the IS31FL319x LED driver to use the extended managed
registration API for parsing properties automatically. It also adds proper
fwnode lifecycle management and defers LED registration until the maximum
aggregated current is calculated.
> leds: is31fl319x: modernize registration
[Severity: Low]
This isn't a bug, but should the description after the subsystem prefix be
capitalized? The LED subsystem guidelines recommend formatting commit messages
as "leds: <Driver>: <Capitalized description>".
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260804-led-modern-v3-1-297720eec19f@kemnade.info?part=1
next prev parent reply other threads:[~2026-08-04 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 13:34 [PATCH v3] leds: is31fl319x: modernize registration Andreas Kemnade
2026-08-04 13:55 ` sashiko-bot [this message]
2026-08-04 14:41 ` Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804135515.5DBFC1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=andreas@kemnade.info \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox