From: Andreas Kemnade <andreas@kemnade.info>
To: sashiko-bot@kernel.org
Cc: sashiko-reviews@lists.linux.dev, lee@kernel.org,
linux-leds@vger.kernel.org,
"H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH v3] leds: is31fl319x: modernize registration
Date: Tue, 4 Aug 2026 16:41:01 +0200 [thread overview]
Message-ID: <20260804164101.43753f1b@kemnade.info> (raw)
In-Reply-To: <20260804135515.5DBFC1F000E9@smtp.kernel.org>
On Tue, 04 Aug 2026 13:55:14 +0000
sashiko-bot@kernel.org wrote:
> > leds: is31fl319x: modernize registration
>
> [Severity: Low]
> This isn't a bug, but should the description after the subsystem prefix be
> capitalized? The LED subsystem guidelines recommend formatting commit messages
> as "leds: <Driver>: <Capitalized description>".
~/linux$ grep -R 'leds: <Driver>: <Capitalized description>"' Documentation/
~/linux$ ls Documentation/leds/
index.rst leds-lp5521.rst leds-sc27xx.rst
leds-blinkm.rst leds-lp5523.rst leds-st1202.rst
leds-cht-wcove.rst leds-lp5562.rst ledtrig-oneshot.rst
leds-class-flash.rst leds-lp55xx.rst ledtrig-transient.rst
leds-class-multicolor.rst leds-lp5812.rst ledtrig-usbport.rst
leds-class.rst leds-mlxcpld.rst uleds.rst
leds-el15203000.rst leds-mt6370-rgb.rst well-known-leds.txt
leds-lm3556.rst leds-qcom-lpg.rst
leds-lp3944.rst leds-s2m-rgb.rst
nothing look like special guidelines for the system. I do not want to
see such comments without a reference.
Also MAINTAINERS does not show any additional policy for the LED subsystem.
Regards,
Andreas
prev parent reply other threads:[~2026-08-04 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 13:34 [PATCH v3] leds: is31fl319x: modernize registration Andreas Kemnade
2026-08-04 13:55 ` sashiko-bot
2026-08-04 14:41 ` Andreas Kemnade [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804164101.43753f1b@kemnade.info \
--to=andreas@kemnade.info \
--cc=hns@goldelico.com \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox