* [PATCH v2] dt-bindings: leds: lacie,netxbig-leds: Convert to DT schema
@ 2026-08-21 12:37 Udaya Kiran Challa
2026-08-21 12:55 ` sashiko-bot
2026-08-31 14:14 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Udaya Kiran Challa @ 2026-08-21 12:37 UTC (permalink / raw)
To: lee, pavel, robh, krzk+dt, conor+dt
Cc: skhan, me, linux-leds, devicetree, linux-kernel,
Udaya Kiran Challa
Convert lacie,netxbig-leds devicetree binding from legacy
text format to DT schema.
Signed-off-by: Udaya Kiran Challa <challauday369@gmail.com>
---
Changelog:
Changes since v1:
- Use pattenProperties for LED child nodes instead of additionalProperties
- Explicitly list the two optional properties supported by the binding
- Place the top-level required block after child-node definition
Link to v1:https://lore.kernel.org/all/20260820150223.108374-1-challauday369@gmail.com/
---
.../bindings/leds/lacie,netxbig-leds.yaml | 144 ++++++++++++++++++
.../devicetree/bindings/leds/leds-netxbig.txt | 92 -----------
2 files changed, 144 insertions(+), 92 deletions(-)
create mode 100644 Documentation/devicetree/bindings/leds/lacie,netxbig-leds.yaml
delete mode 100644 Documentation/devicetree/bindings/leds/leds-netxbig.txt
diff --git a/Documentation/devicetree/bindings/leds/lacie,netxbig-leds.yaml b/Documentation/devicetree/bindings/leds/lacie,netxbig-leds.yaml
new file mode 100644
index 000000000000..02759ecb32d0
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/lacie,netxbig-leds.yaml
@@ -0,0 +1,144 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/lacie,netxbig-leds.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: LaCie/Seagate netxbig CPLD LEDs
+
+maintainers:
+ - Simon Guinot <simon.guinot@sequanux.org>
+
+description: |
+ Binding for the CPLD LEDs (GPIO extension bus) found on some LaCie/Seagate
+ boards (Example: 2Big/5Big Network v2, 2Big NAS).
+
+properties:
+ compatible:
+ const: lacie,netxbig-leds
+
+ gpio-ext:
+ description: Phandle for the gpio-ext bus.
+ $ref: /schemas/types.yaml#/definitions/phandle
+
+ timers:
+ description: |
+ Timer array. Each timer entry is represented by three integers:
+ Mode (gpio-ext bus), delay_on and delay_off.
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+
+patternProperties:
+ "^(?!gpio-ext$|pinctrl-[0-9]+$)[a-z][a-z0-9]*(-[a-z0-9]+)+$":
+ type: object
+ additionalProperties: false
+
+ properties:
+ label:
+ description: |
+ Name for this LED. If omitted, the label is taken from the node name.
+ $ref: /schemas/types.yaml#/definitions/string
+
+ mode-addr:
+ description: Mode register address on gpio-ext bus.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ mode-val:
+ description: |
+ Mode to value mapping. Each entry is represented by two integers:
+ a mode and the corresponding value on the gpio-ext bus.
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+
+ bright-addr:
+ description: Brightness register address on gpio-ext bus.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ max-brightness:
+ description: Maximum brightness value.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ linux,default-trigger:
+ description: Trigger assigned to the LED.
+ $ref: /schemas/types.yaml#/definitions/string
+
+ required:
+ - mode-addr
+ - mode-val
+ - bright-addr
+ - max-brightness
+
+required:
+ - compatible
+ - gpio-ext
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/leds/leds-netxbig.h>
+
+ netxbig-leds {
+ compatible = "lacie,netxbig-leds";
+
+ gpio-ext = <&netxbig_gpio_ext>;
+
+ timers = <NETXBIG_LED_TIMER1 500 500
+ NETXBIG_LED_TIMER2 500 1000>;
+
+ blue-power {
+ label = "netxbig:blue:power";
+ mode-addr = <0>;
+ mode-val = <NETXBIG_LED_OFF 0
+ NETXBIG_LED_ON 1
+ NETXBIG_LED_TIMER1 3
+ NETXBIG_LED_TIMER2 7>;
+ bright-addr = <1>;
+ max-brightness = <7>;
+ };
+ red-power {
+ label = "netxbig:red:power";
+ mode-addr = <0>;
+ mode-val = <NETXBIG_LED_OFF 0
+ NETXBIG_LED_ON 2
+ NETXBIG_LED_TIMER1 4>;
+ bright-addr = <1>;
+ max-brightness = <7>;
+ };
+ blue-sata0 {
+ label = "netxbig:blue:sata0";
+ mode-addr = <3>;
+ mode-val = <NETXBIG_LED_OFF 0
+ NETXBIG_LED_ON 7
+ NETXBIG_LED_SATA 1
+ NETXBIG_LED_TIMER1 3>;
+ bright-addr = <2>;
+ max-brightness = <7>;
+ };
+ red-sata0 {
+ label = "netxbig:red:sata0";
+ mode-addr = <3>;
+ mode-val = <NETXBIG_LED_OFF 0
+ NETXBIG_LED_ON 2
+ NETXBIG_LED_TIMER1 4>;
+ bright-addr = <2>;
+ max-brightness = <7>;
+ };
+ blue-sata1 {
+ label = "netxbig:blue:sata1";
+ mode-addr = <4>;
+ mode-val = <NETXBIG_LED_OFF 0
+ NETXBIG_LED_ON 7
+ NETXBIG_LED_SATA 1
+ NETXBIG_LED_TIMER1 3>;
+ bright-addr = <2>;
+ max-brightness = <7>;
+ };
+ red-sata1 {
+ label = "netxbig:red:sata1";
+ mode-addr = <4>;
+ mode-val = <NETXBIG_LED_OFF 0
+ NETXBIG_LED_ON 2
+ NETXBIG_LED_TIMER1 4>;
+ bright-addr = <2>;
+ max-brightness = <7>;
+ };
+ };
diff --git a/Documentation/devicetree/bindings/leds/leds-netxbig.txt b/Documentation/devicetree/bindings/leds/leds-netxbig.txt
deleted file mode 100644
index 5ef92a26d768..000000000000
--- a/Documentation/devicetree/bindings/leds/leds-netxbig.txt
+++ /dev/null
@@ -1,92 +0,0 @@
-Binding for the CPLD LEDs (GPIO extension bus) found on some LaCie/Seagate
-boards (Example: 2Big/5Big Network v2, 2Big NAS).
-
-Required properties:
-- compatible: "lacie,netxbig-leds".
-- gpio-ext: Phandle for the gpio-ext bus.
-
-Optional properties:
-- timers: Timer array. Each timer entry is represented by three integers:
- Mode (gpio-ext bus), delay_on and delay_off.
-
-Each LED is represented as a sub-node of the netxbig-leds device.
-
-Required sub-node properties:
-- mode-addr: Mode register address on gpio-ext bus.
-- mode-val: Mode to value mapping. Each entry is represented by two integers:
- A mode and the corresponding value on the gpio-ext bus.
-- bright-addr: Brightness register address on gpio-ext bus.
-- max-brightness: Maximum brightness value.
-
-Optional sub-node properties:
-- label: Name for this LED. If omitted, the label is taken from the node name.
-- linux,default-trigger: Trigger assigned to the LED.
-
-Example:
-
-netxbig-leds {
- compatible = "lacie,netxbig-leds";
-
- gpio-ext = &gpio_ext;
-
- timers = <NETXBIG_LED_TIMER1 500 500
- NETXBIG_LED_TIMER2 500 1000>;
-
- blue-power {
- label = "netxbig:blue:power";
- mode-addr = <0>;
- mode-val = <NETXBIG_LED_OFF 0
- NETXBIG_LED_ON 1
- NETXBIG_LED_TIMER1 3
- NETXBIG_LED_TIMER2 7>;
- bright-addr = <1>;
- max-brightness = <7>;
- };
- red-power {
- label = "netxbig:red:power";
- mode-addr = <0>;
- mode-val = <NETXBIG_LED_OFF 0
- NETXBIG_LED_ON 2
- NETXBIG_LED_TIMER1 4>;
- bright-addr = <1>;
- max-brightness = <7>;
- };
- blue-sata0 {
- label = "netxbig:blue:sata0";
- mode-addr = <3>;
- mode-val = <NETXBIG_LED_OFF 0
- NETXBIG_LED_ON 7
- NETXBIG_LED_SATA 1
- NETXBIG_LED_TIMER1 3>;
- bright-addr = <2>;
- max-brightness = <7>;
- };
- red-sata0 {
- label = "netxbig:red:sata0";
- mode-addr = <3>;
- mode-val = <NETXBIG_LED_OFF 0
- NETXBIG_LED_ON 2
- NETXBIG_LED_TIMER1 4>;
- bright-addr = <2>;
- max-brightness = <7>;
- };
- blue-sata1 {
- label = "netxbig:blue:sata1";
- mode-addr = <4>;
- mode-val = <NETXBIG_LED_OFF 0
- NETXBIG_LED_ON 7
- NETXBIG_LED_SATA 1
- NETXBIG_LED_TIMER1 3>;
- bright-addr = <2>;
- max-brightness = <7>;
- };
- red-sata1 {
- label = "netxbig:red:sata1";
- mode-addr = <4>;
- mode-val = <NETXBIG_LED_OFF 0
- NETXBIG_LED_ON 2
- NETXBIG_LED_TIMER1 4>;
- bright-addr = <2>;
- max-brightness = <7>;
- };
-};
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: leds: lacie,netxbig-leds: Convert to DT schema
2026-08-21 12:37 [PATCH v2] dt-bindings: leds: lacie,netxbig-leds: Convert to DT schema Udaya Kiran Challa
@ 2026-08-21 12:55 ` sashiko-bot
2026-08-31 14:14 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-08-21 12:55 UTC (permalink / raw)
To: Udaya Kiran Challa; +Cc: robh, conor+dt, linux-leds, lee, devicetree
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The YAML binding schema for LED child nodes explicitly forbids standard LED properties by using 'additionalProperties: false' without referencing the common LED schema.
- [Medium] The regular expression used in `patternProperties` to match child nodes is brittle: it arbitrarily rejects valid single-word node names and would erroneously match hyphenated top-level properties.
--
--- Patch [1]: [PATCH v2] dt-bindings: leds: lacie,netxbig-leds: Convert to DT schema ---
commit a7a7b0d43884f0f2164a9d243e2d08d00c94a010
Author: Udaya Kiran Challa <challauday369@gmail.com>
dt-bindings: leds: lacie,netxbig-leds: Convert to DT schema
This commit converts the LaCie/Seagate netxbig CPLD LEDs devicetree
binding from the legacy text format to the YAML DT schema.
Link to v1:https://lore.kernel.org/all/20260820150223.108374-1-challauday369@gmail.com/
> diff --git a/Documentation/devicetree/bindings/leds/lacie,netxbig-leds.yaml b/Documentation/devicetree/bindings/leds/lacie,netxbig-leds.yaml
> new file mode 100644
> index 0000000000000..02759ecb32d04
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/lacie,netxbig-leds.yaml
[ ... ]
> +patternProperties:
> + "^(?!gpio-ext$|pinctrl-[0-9]+$)[a-z][a-z0-9]*(-[a-z0-9]+)+$":
[Severity: Medium]
Does this regular expression arbitrarily reject valid single-word node
names like led or sata?
The regex requires at least one hyphen. A child node simply named led
would fail to match here, fall through to the top-level
additionalProperties: false, and be completely rejected.
It could also erroneously match future standard hyphenated properties like
power-domains and expect them to contain LED properties.
> + type: object
> + additionalProperties: false
> +
> + properties:
> + label:
[Severity: Medium]
Does setting additionalProperties: false here without referencing the
common LED schema prevent the use of standard properties like color and
function?
Because the schema validator will reject any unlisted properties, device
trees cannot be modernized to use standard LED subsystem properties, which
are explicitly recommended over the deprecated label property.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260821123723.198286-1-challauday369@gmail.com?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: leds: lacie,netxbig-leds: Convert to DT schema
2026-08-21 12:37 [PATCH v2] dt-bindings: leds: lacie,netxbig-leds: Convert to DT schema Udaya Kiran Challa
2026-08-21 12:55 ` sashiko-bot
@ 2026-08-31 14:14 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2026-08-31 14:14 UTC (permalink / raw)
To: Udaya Kiran Challa
Cc: lee, pavel, krzk+dt, conor+dt, skhan, me, linux-leds, devicetree,
linux-kernel
On Fri, Aug 21, 2026 at 06:07:23PM +0530, Udaya Kiran Challa wrote:
> Convert lacie,netxbig-leds devicetree binding from legacy
> text format to DT schema.
>
> Signed-off-by: Udaya Kiran Challa <challauday369@gmail.com>
> ---
> Changelog:
>
> Changes since v1:
> - Use pattenProperties for LED child nodes instead of additionalProperties
> - Explicitly list the two optional properties supported by the binding
> - Place the top-level required block after child-node definition
>
> Link to v1:https://lore.kernel.org/all/20260820150223.108374-1-challauday369@gmail.com/
> ---
> .../bindings/leds/lacie,netxbig-leds.yaml | 144 ++++++++++++++++++
> .../devicetree/bindings/leds/leds-netxbig.txt | 92 -----------
> 2 files changed, 144 insertions(+), 92 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/leds/lacie,netxbig-leds.yaml
> delete mode 100644 Documentation/devicetree/bindings/leds/leds-netxbig.txt
>
> diff --git a/Documentation/devicetree/bindings/leds/lacie,netxbig-leds.yaml b/Documentation/devicetree/bindings/leds/lacie,netxbig-leds.yaml
> new file mode 100644
> index 000000000000..02759ecb32d0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/lacie,netxbig-leds.yaml
> @@ -0,0 +1,144 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/lacie,netxbig-leds.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LaCie/Seagate netxbig CPLD LEDs
> +
> +maintainers:
> + - Simon Guinot <simon.guinot@sequanux.org>
> +
> +description: |
> + Binding for the CPLD LEDs (GPIO extension bus) found on some LaCie/Seagate
> + boards (Example: 2Big/5Big Network v2, 2Big NAS).
> +
> +properties:
> + compatible:
> + const: lacie,netxbig-leds
> +
> + gpio-ext:
> + description: Phandle for the gpio-ext bus.
> + $ref: /schemas/types.yaml#/definitions/phandle
> +
> + timers:
> + description: |
> + Timer array. Each timer entry is represented by three integers:
> + Mode (gpio-ext bus), delay_on and delay_off.
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> +
> +patternProperties:
> + "^(?!gpio-ext$|pinctrl-[0-9]+$)[a-z][a-z0-9]*(-[a-z0-9]+)+$":
> + type: object
> + additionalProperties: false
You need a $ref to led common.yaml.
> +
> + properties:
> + label:
> + description: |
> + Name for this LED. If omitted, the label is taken from the node name.
> + $ref: /schemas/types.yaml#/definitions/string
And drop the type on all the common properties.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-31 14:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-21 12:37 [PATCH v2] dt-bindings: leds: lacie,netxbig-leds: Convert to DT schema Udaya Kiran Challa
2026-08-21 12:55 ` sashiko-bot
2026-08-31 14:14 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox