Re: [RFC v7 1/1] leds: asus-aura-scsi: Add ASUS Aura RGB LED driver for ROG NVMe enclosures

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] leds: undefined kzalloc_obj() macro usage
- [Low] leds: blk_rq_map_kern() missing request_queue argument
--

commit e0971e949056a90448861cfc243c852426110000
Author: Liang Haowen <nbg2974@gmail.com>
leds: asus-aura-scsi: Add ASUS Aura RGB LED driver for ROG NVMe enclosures

This commit introduces the ASUS Aura RGB LED driver for ROG external NVMe
enclosures. The driver manages the ENE LED controller using vendor SCSI
commands.

> --- a/drivers/leds/rgb/leds-asus-aura-scsi.c
> +++ b/drivers/leds/rgb/leds-asus-aura-scsi.c
[ ... ]
>  static int ene_write(struct scsi_device *sdev, u16 reg,
>  		     const void *data, u8 arg_count)
>  {
>  	struct request *rq;
>  	struct scsi_cmnd *scmd;
>  	u8 cdb[ENE_CDB_LEN];
>  	int ret;
>  
>  	ene_build_cdb(cdb, reg, arg_count);
>  
>  	rq = scsi_alloc_request(sdev->request_queue, REQ_OP_DRV_OUT, 0);
>  	if (IS_ERR(rq))
>  		return PTR_ERR(rq);
>  
>  	if (arg_count) {
>  		ret = blk_rq_map_kern(rq, (void *)data, arg_count, GFP_NOIO);

[Severity: Low]
Does this code omit the request_queue argument when calling
blk_rq_map_kern()? The blk_rq_map_kern() API requires five parameters,
starting with the queue pointer, but only four are passed here. This causes
a compilation error due to too few arguments.

[ ... ]
>  static int asus_aura_attach(struct scsi_device *sdev)
>  {
>  	struct asus_aura_zone *zone;
>  	int i, ret;
>  
>  	if (strncmp(sdev->vendor, ARION_INQ_VENDOR, strlen(ARION_INQ_VENDOR)) ||
>  	    strncmp(sdev->model, ARION_INQ_MODEL, strlen(ARION_INQ_MODEL)))
>  		return SCSI_DH_DEV_UNSUPP;
>  
>  	zone = kzalloc_obj(*zone, GFP_KERNEL);

[Severity: Low]
Is kzalloc_obj() a valid macro or function in the kernel? Using an
undefined identifier here causes a compilation failure when allocating the
primary data structure. The standard API for this allocation would be
kzalloc().

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923103015.2365773-1-nbg2974@gmail.com?part=1