From: sashiko-bot@kernel.org
To: "Wayne Ho" <wayneho219@gmail.com>
Cc: lee@kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH 1/2] Documentation: ABI: leds: inverted is specific to the backlight trigger
Date: Thu, 01 Oct 2026 06:48:24 +0000 [thread overview]
Message-ID: <20261001064825.1113A1F0089A@smtp.kernel.org> (raw)
In-Reply-To: <20261001-docs-leds-abi-trigger-attrs-v1-1-54f0529bf0f6@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] leds: commit message description is not capitalized
--
commit 3ae418ca93d0206cc940b490c5c31c35740d2dcd
Author: Wayne Ho <wayneho219@gmail.com>
Documentation: ABI: leds: inverted is specific to the backlight trigger
This commit updates the documentation for the inverted attribute in the
LED subsystem to clarify that it is now only created by the backlight
trigger. It drops the outdated reference to the gpio trigger.
> Documentation: ABI: leds: inverted is specific to the backlight trigger
[Severity: Low]
This isn't a bug, but does the commit subject line violate the LED
subsystem capitalization guidelines? The description portion after the
subsystem prefix is expected to be capitalized, meaning "inverted" should
be "Inverted".
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261001-docs-leds-abi-trigger-attrs-v1-0-54f0529bf0f6@gmail.com?part=1
next prev parent reply other threads:[~2026-10-01 6:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 6:45 [PATCH 0/2] Documentation: ABI: leds: document shared trigger attributes Wayne Ho via B4 Relay
2026-10-01 6:45 ` [PATCH 1/2] Documentation: ABI: leds: inverted is specific to the backlight trigger Wayne Ho via B4 Relay
2026-10-01 6:48 ` sashiko-bot [this message]
2026-10-05 10:43 ` Griffin Kroah-Hartman
2026-10-05 15:35 ` Wayne Ho
2026-10-01 6:45 ` [PATCH 2/2] Documentation: ABI: leds: document timer, heartbeat and activity attributes Wayne Ho via B4 Relay
2026-10-01 6:50 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001064825.1113A1F0089A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wayneho219@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox