From: sashiko-bot@kernel.org
To: "Wayne Ho" <wayneho219@gmail.com>
Cc: lee@kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH 2/2] Documentation: ABI: leds: document timer, heartbeat and activity attributes
Date: Thu, 01 Oct 2026 06:50:00 +0000 [thread overview]
Message-ID: <20261001065001.AD2E31F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261001-docs-leds-abi-trigger-attrs-v1-2-54f0529bf0f6@gmail.com>
> From: Wayne Ho <wayneho219@gmail.com>
>
> The delay_on and delay_off attributes created by the timer trigger and
> the invert attribute created by the heartbeat and activity triggers
> are not documented. They share their sysfs paths with the oneshot
> trigger attributes, so adding a separate entry per trigger would make
> get_abi.py warn about the same path being defined more than once.
>
> Move the delay_on, delay_off and invert entries from
> sysfs-class-led-trigger-oneshot to sysfs-class-led and describe the
> behaviour of each trigger that creates them.
>
> Signed-off-by: Wayne Ho <wayneho219@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261001-docs-leds-abi-trigger-attrs-v1-0-54f0529bf0f6@gmail.com?part=2
prev parent reply other threads:[~2026-10-01 6:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 6:45 [PATCH 0/2] Documentation: ABI: leds: document shared trigger attributes Wayne Ho via B4 Relay
2026-10-01 6:45 ` [PATCH 1/2] Documentation: ABI: leds: inverted is specific to the backlight trigger Wayne Ho via B4 Relay
2026-10-01 6:48 ` sashiko-bot
2026-10-05 10:43 ` Griffin Kroah-Hartman
2026-10-05 15:35 ` Wayne Ho
2026-10-01 6:45 ` [PATCH 2/2] Documentation: ABI: leds: document timer, heartbeat and activity attributes Wayne Ho via B4 Relay
2026-10-01 6:50 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001065001.AD2E31F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wayneho219@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox