* [PATCH] backlight: ktd2801: depend on GPIOLIB
@ 2024-02-13 18:12 Duje Mihanović
2024-02-15 11:44 ` Daniel Thompson
2024-02-15 13:31 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Duje Mihanović @ 2024-02-13 18:12 UTC (permalink / raw)
To: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller,
Linus Walleij, Duje Mihanović
Cc: Arnd Bergmann, Karel Balej, dri-devel, linux-leds, linux-fbdev,
linux-kernel
LEDS_EXPRESSWIRE depends on GPIOLIB, and so must anything selecting it:
WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
Depends on [n]: NEW_LEDS [=y] && GPIOLIB [=n]
Selected by [m]:
- BACKLIGHT_KTD2801 [=m] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE [=m]
Fixes: 66c76c1cd984 ("backlight: Add Kinetic KTD2801 backlight support")
Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
---
drivers/video/backlight/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
index 230bca07b09d..8bd88017d945 100644
--- a/drivers/video/backlight/Kconfig
+++ b/drivers/video/backlight/Kconfig
@@ -185,6 +185,7 @@ config BACKLIGHT_KTD253
config BACKLIGHT_KTD2801
tristate "Backlight Driver for Kinetic KTD2801"
+ depends on GPIOLIB
select LEDS_EXPRESSWIRE
help
Say Y to enable the backlight driver for the Kinetic KTD2801 1-wire
---
base-commit: 46d4e2eb58e14c8935fa0e27d16d4c62ef82849a
change-id: 20240213-ktd2801-deps-0f571c09b824
Best regards,
--
Duje Mihanović <duje.mihanovic@skole.hr>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] backlight: ktd2801: depend on GPIOLIB
2024-02-13 18:12 [PATCH] backlight: ktd2801: depend on GPIOLIB Duje Mihanović
@ 2024-02-15 11:44 ` Daniel Thompson
2024-02-15 13:31 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Daniel Thompson @ 2024-02-15 11:44 UTC (permalink / raw)
To: Duje Mihanović
Cc: Lee Jones, Jingoo Han, Helge Deller, Linus Walleij, Arnd Bergmann,
Karel Balej, dri-devel, linux-leds, linux-fbdev, linux-kernel
On Tue, Feb 13, 2024 at 07:12:33PM +0100, Duje Mihanović wrote:
> LEDS_EXPRESSWIRE depends on GPIOLIB, and so must anything selecting it:
>
> WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
> Depends on [n]: NEW_LEDS [=y] && GPIOLIB [=n]
> Selected by [m]:
> - BACKLIGHT_KTD2801 [=m] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE [=m]
>
> Fixes: 66c76c1cd984 ("backlight: Add Kinetic KTD2801 backlight support")
> Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] backlight: ktd2801: depend on GPIOLIB
2024-02-13 18:12 [PATCH] backlight: ktd2801: depend on GPIOLIB Duje Mihanović
2024-02-15 11:44 ` Daniel Thompson
@ 2024-02-15 13:31 ` Linus Walleij
2024-02-15 14:20 ` Duje Mihanović
1 sibling, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2024-02-15 13:31 UTC (permalink / raw)
To: Duje Mihanović
Cc: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller,
Arnd Bergmann, Karel Balej, dri-devel, linux-leds, linux-fbdev,
linux-kernel
On Tue, Feb 13, 2024 at 7:13 PM Duje Mihanović <duje.mihanovic@skole.hr> wrote:
> LEDS_EXPRESSWIRE depends on GPIOLIB, and so must anything selecting it:
>
> WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
> Depends on [n]: NEW_LEDS [=y] && GPIOLIB [=n]
> Selected by [m]:
> - BACKLIGHT_KTD2801 [=m] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE [=m]
>
> Fixes: 66c76c1cd984 ("backlight: Add Kinetic KTD2801 backlight support")
> Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Technically you can also select GPIOLIB, because it is available on
all platforms, so it may be easier for users, but then you never know
which GPIOs you get in practice.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] backlight: ktd2801: depend on GPIOLIB
2024-02-15 13:31 ` Linus Walleij
@ 2024-02-15 14:20 ` Duje Mihanović
0 siblings, 0 replies; 4+ messages in thread
From: Duje Mihanović @ 2024-02-15 14:20 UTC (permalink / raw)
To: Linus Walleij
Cc: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller,
Arnd Bergmann, Karel Balej, dri-devel, linux-leds, linux-fbdev,
linux-kernel
On Thursday, February 15, 2024 2:31:37 PM CET Linus Walleij wrote:
> On Tue, Feb 13, 2024 at 7:13 PM Duje Mihanović <duje.mihanovic@skole.hr>
wrote:
> > LEDS_EXPRESSWIRE depends on GPIOLIB, and so must anything selecting it:
> >
> > WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
> >
> > Depends on [n]: NEW_LEDS [=y] && GPIOLIB [=n]
> > Selected by [m]:
> > - BACKLIGHT_KTD2801 [=m] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE
[=m]
> >
> > Fixes: 66c76c1cd984 ("backlight: Add Kinetic KTD2801 backlight support")
> > Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Technically you can also select GPIOLIB, because it is available on
> all platforms, so it may be easier for users, but then you never know
> which GPIOs you get in practice.
Now that I think of it, wouldn't that be the better solution? I opted for
"depends on" only because Arnd did the same in his KTD2692 patch, but if
select is better (and it seems to be for users) then I'd go for that in both
patches.
Regards,
--
Duje
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-15 14:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-13 18:12 [PATCH] backlight: ktd2801: depend on GPIOLIB Duje Mihanović
2024-02-15 11:44 ` Daniel Thompson
2024-02-15 13:31 ` Linus Walleij
2024-02-15 14:20 ` Duje Mihanović
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox