From: Guenter Roeck <linux@roeck-us.net>
To: Henning Schild <henning.schild@siemens.com>,
Lee Jones <lee@kernel.org>, Hans de Goede <hdegoede@redhat.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-watchdog@vger.kernel.org
Cc: Pavel Machek <pavel@ucw.cz>, Mark Gross <markgross@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Tobias Schaffner <tobias.schaffner@siemens.com>
Subject: Re: [PATCH v2 1/3] watchdog: make Siemens Simatic watchdog driver default on platform
Date: Wed, 19 Jul 2023 09:33:19 -0700 [thread overview]
Message-ID: <7fd7dbd0-23f7-228a-2645-ada0a60102fd@roeck-us.net> (raw)
In-Reply-To: <20230719153518.13073-2-henning.schild@siemens.com>
On 7/19/23 08:35, Henning Schild wrote:
> If a user did choose to enable Siemens Simatic platform support they
> likely want that driver to be enabled without having to flip more config
> switches. So we make the watchdog driver config switch default to the
> platform driver switches value.
>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index ee97d89dfc11..04e9b40cf7d5 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1681,6 +1681,7 @@ config NIC7018_WDT
> config SIEMENS_SIMATIC_IPC_WDT
> tristate "Siemens Simatic IPC Watchdog"
> depends on SIEMENS_SIMATIC_IPC
> + default y
> select WATCHDOG_CORE
> select P2SB
> help
next prev parent reply other threads:[~2023-07-19 16:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 15:35 [PATCH v2 0/3] platform/x86: move simatic drivers into subdir Henning Schild
2023-07-19 15:35 ` [PATCH v2 1/3] watchdog: make Siemens Simatic watchdog driver default on platform Henning Schild
2023-07-19 16:33 ` Guenter Roeck [this message]
2023-07-19 15:35 ` [PATCH v2 2/3] leds: simatic-ipc-leds: default config switch to platform switch Henning Schild
2023-07-24 9:17 ` Lee Jones
2023-07-19 15:35 ` [PATCH v2 3/3] platform/x86: Move all simatic ipc drivers to the subdirectory siemens Henning Schild
2023-07-31 10:46 ` Hans de Goede
2023-07-19 16:06 ` [PATCH v2 0/3] platform/x86: move simatic drivers into subdir Andy Shevchenko
2023-07-25 14:27 ` Hans de Goede
2023-07-27 9:26 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fd7dbd0-23f7-228a-2645-ada0a60102fd@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=henning.schild@siemens.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tobias.schaffner@siemens.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox