From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Henning Schild <henning.schild@siemens.com>
Cc: Lee Jones <lee@kernel.org>, Hans de Goede <hdegoede@redhat.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-watchdog@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
Mark Gross <markgross@kernel.org>,
Tobias Schaffner <tobias.schaffner@siemens.com>
Subject: Re: [PATCH v2 0/3] platform/x86: move simatic drivers into subdir
Date: Wed, 19 Jul 2023 19:06:04 +0300 [thread overview]
Message-ID: <ZLgJ7Oz1XlicGzEn@smile.fi.intel.com> (raw)
In-Reply-To: <20230719153518.13073-1-henning.schild@siemens.com>
On Wed, Jul 19, 2023 at 05:35:15PM +0200, Henning Schild wrote:
> change since v1:
> - switch LED/wdt Kconfig to "default y"
> - remove guard which could hide whole siemens submenu, and default m
>
> This series does two things. It builds up a Kconfig inheritance chain
> for all platform device drivers, namely Watchdog and LED. And then it
> puts all Siemens Simatic IPC drivers in the platform/x86/ directory in
> a subdirectory called "siemens".
>
> That is so that users have to flip less config switches, and to ease
> maintenance.
All three good enough, although I prefer the ordering that 'tristate'
followed by 'default' without interleaved 'depends on'. I leave it
to Hans. Other that that,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-19 16:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 15:35 [PATCH v2 0/3] platform/x86: move simatic drivers into subdir Henning Schild
2023-07-19 15:35 ` [PATCH v2 1/3] watchdog: make Siemens Simatic watchdog driver default on platform Henning Schild
2023-07-19 16:33 ` Guenter Roeck
2023-07-19 15:35 ` [PATCH v2 2/3] leds: simatic-ipc-leds: default config switch to platform switch Henning Schild
2023-07-24 9:17 ` Lee Jones
2023-07-19 15:35 ` [PATCH v2 3/3] platform/x86: Move all simatic ipc drivers to the subdirectory siemens Henning Schild
2023-07-31 10:46 ` Hans de Goede
2023-07-19 16:06 ` Andy Shevchenko [this message]
2023-07-25 14:27 ` [PATCH v2 0/3] platform/x86: move simatic drivers into subdir Hans de Goede
2023-07-27 9:26 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLgJ7Oz1XlicGzEn@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=henning.schild@siemens.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=markgross@kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tobias.schaffner@siemens.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox