* ledtrig_flash_ctrl and ledtrig_torch_ctrl
@ 2025-01-26 2:34 Dr. David Alan Gilbert
2025-02-10 17:09 ` Lee Jones
0 siblings, 1 reply; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2025-01-26 2:34 UTC (permalink / raw)
To: linux-leds
Hi,
One of my scripts noticed that ledtrig_flash_ctrl() and
ledtrig_torch_ctrl() don't seem to be called anywhere,
and don't seem to have been since they were added in 2013.
Are they actually deadcode I can/should remove?
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ledtrig_flash_ctrl and ledtrig_torch_ctrl
2025-01-26 2:34 ledtrig_flash_ctrl and ledtrig_torch_ctrl Dr. David Alan Gilbert
@ 2025-02-10 17:09 ` Lee Jones
2025-02-10 18:36 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 3+ messages in thread
From: Lee Jones @ 2025-02-10 17:09 UTC (permalink / raw)
To: Dr. David Alan Gilbert; +Cc: linux-leds
On Sun, 26 Jan 2025, Dr. David Alan Gilbert wrote:
> Hi,
> One of my scripts noticed that ledtrig_flash_ctrl() and
> ledtrig_torch_ctrl() don't seem to be called anywhere,
> and don't seem to have been since they were added in 2013.
>
> Are they actually deadcode I can/should remove?
I would ping the authors first. If there are no good reasons to keep
them around come back, you can remove them.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ledtrig_flash_ctrl and ledtrig_torch_ctrl
2025-02-10 17:09 ` Lee Jones
@ 2025-02-10 18:36 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2025-02-10 18:36 UTC (permalink / raw)
To: Lee Jones, pavel, Milo.Kim; +Cc: linux-leds
Copying in Milo
* Lee Jones (lee@kernel.org) wrote:
> On Sun, 26 Jan 2025, Dr. David Alan Gilbert wrote:
>
> > Hi,
> > One of my scripts noticed that ledtrig_flash_ctrl() and
> > ledtrig_torch_ctrl() don't seem to be called anywhere,
> > and don't seem to have been since they were added in 2013.
> >
> > Are they actually deadcode I can/should remove?
>
> I would ping the authors first. If there are no good reasons to keep
> them around come back, you can remove them.
OK, copied in.
Dave
> --
> Lee Jones [李琼斯]
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-10 18:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-26 2:34 ledtrig_flash_ctrl and ledtrig_torch_ctrl Dr. David Alan Gilbert
2025-02-10 17:09 ` Lee Jones
2025-02-10 18:36 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox