[PATCH v2 1/2] leds: lm3532: Propagate enable GPIO errors

[PATCH v2 1/2] leds: lm3532: Propagate enable GPIO errors

[phucduc.bui]

From: bui duc phuc <phucduc.bui@gmail.com>

devm_gpiod_get_optional() returns NULL when the optional GPIO is not
present, but may return -EPROBE_DEFER or other errors.

lm3532_parse_node() currently treats GPIO lookup errors as if the GPIO
were not present.

Check the return value and propagate errors from the enable GPIO lookup.

Fixes: bc1b8492c764 ("leds: lm3532: Introduce the lm3532 LED driver")
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---

Changes in v2:
 - Capitalize the first letter of the commit message subject 

 drivers/leds/leds-lm3532.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/leds/leds-lm3532.c b/drivers/leds/leds-lm3532.c
index b51496910b08..a3bc9680dc4c 100644
--- a/drivers/leds/leds-lm3532.c
+++ b/drivers/leds/leds-lm3532.c
@@ -560,7 +560,8 @@ static int lm3532_parse_node(struct lm3532_data *priv)
 	priv->enable_gpio = devm_gpiod_get_optional(&priv->client->dev,
 						   "enable", GPIOD_OUT_LOW);
 	if (IS_ERR(priv->enable_gpio))
-		priv->enable_gpio = NULL;
+		return dev_err_probe(&priv->client->dev, PTR_ERR(priv->enable_gpio),
+				     "failed to get enable GPIO\n");
 
 	if (priv->enable_gpio) {
 		ret = devm_add_action(&priv->client->dev, gpio_set_low_action, priv);
-- 
2.43.0

[PATCH v2 2/2] leds: lm3532: Avoid duplicate error messages

[phucduc.bui]

From: bui duc phuc <phucduc.bui@gmail.com>

Most error paths in lm3532_parse_node() already log errors. Add an
error message for the devm_add_action() failure and remove the
redundant error message from lm3532_probe() to avoid duplicate logs.

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
 drivers/leds/leds-lm3532.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/leds/leds-lm3532.c b/drivers/leds/leds-lm3532.c
index a3bc9680dc4c..05856c053fac 100644
--- a/drivers/leds/leds-lm3532.c
+++ b/drivers/leds/leds-lm3532.c
@@ -566,7 +566,8 @@ static int lm3532_parse_node(struct lm3532_data *priv)
 	if (priv->enable_gpio) {
 		ret = devm_add_action(&priv->client->dev, gpio_set_low_action, priv);
 		if (ret)
-			return ret;
+			return dev_err_probe(&priv->client->dev, ret,
+					     "failed to add GPIO action\n");
 	}
 
 	priv->regulator = devm_regulator_get(&priv->client->dev, "vin");
@@ -708,10 +709,8 @@ static int lm3532_probe(struct i2c_client *client)
 	i2c_set_clientdata(client, drvdata);
 
 	ret = lm3532_parse_node(drvdata);
-	if (ret) {
-		dev_err(&client->dev, "Failed to parse node\n");
+	if (ret)
 		return ret;
-	}
 
 	return ret;
 }
-- 
2.43.0

Re: [PATCH v2 1/2] leds: lm3532: Propagate enable GPIO errors

[sashiko-bot]

> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> devm_gpiod_get_optional() returns NULL when the optional GPIO is not
> present, but may return -EPROBE_DEFER or other errors.
> 
> lm3532_parse_node() currently treats GPIO lookup errors as if the GPIO
> were not present.
> 
> Check the return value and propagate errors from the enable GPIO lookup.
> 
> Fixes: bc1b8492c764 ("leds: lm3532: Introduce the lm3532 LED driver")
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009091059.25729-1-phucduc.bui@gmail.com?part=1

Re: [PATCH v2 2/2] leds: lm3532: Avoid duplicate error messages

[sashiko-bot]

> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> Most error paths in lm3532_parse_node() already log errors. Add an
> error message for the devm_add_action() failure and remove the
> redundant error message from lm3532_probe() to avoid duplicate logs.
> 
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009091059.25729-1-phucduc.bui@gmail.com?part=2

Re: [PATCH v2 1/2] leds: lm3532: Propagate enable GPIO errors

[Lee Jones]

On Fri, 09 Oct 2026, phucduc.bui@gmail.com wrote:

> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> devm_gpiod_get_optional() returns NULL when the optional GPIO is not
> present, but may return -EPROBE_DEFER or other errors.
> 
> lm3532_parse_node() currently treats GPIO lookup errors as if the GPIO
> were not present.
> 
> Check the return value and propagate errors from the enable GPIO lookup.
> 
> Fixes: bc1b8492c764 ("leds: lm3532: Introduce the lm3532 LED driver")
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
> 
> Changes in v2:
>  - Capitalize the first letter of the commit message subject 
> 
>  drivers/leds/leds-lm3532.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/leds-lm3532.c b/drivers/leds/leds-lm3532.c
> index b51496910b08..a3bc9680dc4c 100644
> --- a/drivers/leds/leds-lm3532.c
> +++ b/drivers/leds/leds-lm3532.c
> @@ -560,7 +560,8 @@ static int lm3532_parse_node(struct lm3532_data *priv)
>  	priv->enable_gpio = devm_gpiod_get_optional(&priv->client->dev,
>  						   "enable", GPIOD_OUT_LOW);
>  	if (IS_ERR(priv->enable_gpio))
> -		priv->enable_gpio = NULL;
> +		return dev_err_probe(&priv->client->dev, PTR_ERR(priv->enable_gpio),
> +				     "failed to get enable GPIO\n");

This changes the semantics of the GPIO handling.

Currently we treat the GPIO as optional, regardless of what is returned.

Ideally we'd have the author review this - did you Cc them?

>  	if (priv->enable_gpio) {
>  		ret = devm_add_action(&priv->client->dev, gpio_set_low_action, priv);
> -- 
> 2.43.0
> 

-- 
Lee Jones

Re: [PATCH v2 1/2] leds: lm3532: Propagate enable GPIO errors

[Bui Duc Phuc]

Hi Lee,

>
> Ideally we'd have the author review this - did you Cc them?
>

Yes, I Cc'd both authors listed in commit bc1b8492c764:
Dan Murphy and Jacek Anaszewski.

Best regards,
Phuc