Re: [PATCH 1/3] dt-bindings: leds: add Realtek RTL9301 port LEDs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: leds: rtl9301-port-leds example uses raw function string
--

commit c5aa8893c90e31ee15e18fbf27c8f17550a77f2f
Author: Ross Cawston <ross@r-sc.ca>

dt-bindings: leds: add Realtek RTL9301 port LEDs

This commit adds a devicetree binding schema for Realtek RTL9300 switch
port LEDs controlled by software.

> diff --git a/Documentation/devicetree/bindings/leds/realtek,rtl9301-port-leds.yaml b/Documentation/devicetree/bindings/leds/realtek,rtl9301-port-leds.yaml
> new file mode 100644
> index 0000000000000..8d6b35525263f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/realtek,rtl9301-port-leds.yaml
> @@ -0,0 +1,84 @@

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/leds/common.h>
> +
> +    led-controller@cc48 {
> +        compatible = "realtek,rtl9301-port-leds";
> +        reg = <0xcc48 0x84>;
> +        #address-cells = <2>;
> +        #size-cells = <0>;
> +
> +        led@0,2 {
> +            reg = <0 2>;
> +            color = <LED_COLOR_ID_GREEN>;
> +            function = "poe";
> +            function-enumerator = <1>;
> +        };
> +
> +        led@8,2 {
> +            reg = <8 2>;
> +            color = <LED_COLOR_ID_GREEN>;
> +            function = "poe";
> +            function-enumerator = <2>;
> +        };
> +    };

[Severity: Low]
In Documentation/devicetree/bindings/leds/realtek,rtl9301-port-leds.yaml,
the ^led@[0-9a-f]+,[0-3]$ child nodes reference /schemas/leds/common.yaml#,
where properties:function states:

  function:
    description:
      LED function. Use one of the LED_FUNCTION_* prefixed definitions
      from the header include/dt-bindings/leds/common.h. If there is no
      matching LED_FUNCTION available, add a new one.

Should the example use a LED_FUNCTION_* macro from
include/dt-bindings/leds/common.h (or define LED_FUNCTION_POE there)
instead of the raw string literal "poe"?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261018194339.132-1-ross@r-sc.ca?part=1