From: sashiko-bot@kernel.org
To: "Arthur Crepin Leblond" <arthur@marmottus.net>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH 1/3] leds: lp55xx: Add program and mux base pages to the device config
Date: Mon, 26 Oct 2026 13:59:45 +0000 [thread overview]
Message-ID: <sashiko-outbox-185361@kernel.org> (raw)
In-Reply-To: <20261026-lp55xx-v1-1-6eaaf530115c@marmottus.net>
> Add program and mux base page to struct lp55xx_device_config to
> set the first page of the engine programs and of the LED mapping table.
>
> Until now the mapping tables were placed at the end of the programs.
> On the LP5569 this puts them in the upper half of the SRAM, while the
> map_* instructions can only address words 0-127.
> This change allows placing the mapping tables before the programs instead.
>
> All the chips set the values matching their current layout, so their
> behavior is unchanged:
> - LP5523 has the 3 engine programs on the first 3 pages and their
> LED mapping tables on the next 3 pages.
> - LP5569 has the 3 engine programs of 4 pages each, followed by the
> LED mapping tables.
> - LP8501 stores its program at address 0.
>
> Signed-off-by: Arthur Crepin Leblond <arthur@marmottus.net>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261026-lp55xx-v1-0-6eaaf530115c@marmottus.net?part=1
next prev parent reply other threads:[~2026-10-26 13:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 13:55 [PATCH 0/3] leds: lp55xx: Fix the LP5569 LED mapping table placement Arthur Crepin Leblond
2026-10-26 13:55 ` [PATCH 1/3] leds: lp55xx: Add program and mux base pages to the device config Arthur Crepin Leblond
2026-10-26 13:59 ` sashiko-bot [this message]
2026-10-26 13:55 ` [PATCH 2/3] leds: leds-lp5569: Place the LED mapping table in the lower half of the SRAM Arthur Crepin Leblond
2026-10-26 14:02 ` sashiko-bot
2026-10-26 13:55 ` [PATCH 3/3] Documentation: leds: lp55xx: Add an LP5569 example Arthur Crepin Leblond
2026-10-26 14:00 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-185361@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=arthur@marmottus.net \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox