Re: [PATCH 2/3] leds: leds-lp5569: Place the LED mapping table in the lower half of the SRAM

[sashiko-bot@kernel.org]

> The LED mapping instructions (map_start, load_end, map_addr, ...) take
> a 7-bits absolute SRAM address, so the mapping table must be in the
> lower half of the SRAM (0-127).
> The driver placed the muxing info after the engine programs, which
> these instructions cannot reach.
> 
> Place the mapping tables in pages 0-2 and the engine programs after
> them.
> 
> This changes the SRAM layout seen by userspace:
> 
>   - The program of engines 1/2/3 now starts at address 0x30/0x70/0xb0
>     instead of 0x00/0x40/0x80 (ENGINEx_PROG_START).
>   - The mapping of engines 1/2/3 is at address 0x00/0x10/0x20.
> 
> Programs loaded through engineN_load or the firmware interface are not
> affected, since they are written relative to the start of the engine.
> Programs that use absolute SRAM addresses (map_start, load_end,
> load_addr, map_addr) must be updated to the new layout.
> 
> Fixes: 30c6743cc89c ("leds: leds-lp5569: Add support for Texas Instruments LP5569")
> Signed-off-by: Arthur Crepin Leblond <arthur@marmottus.net>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261026-lp55xx-v1-0-6eaaf530115c@marmottus.net?part=2