From: sashiko-bot@kernel.org
To: "Zhu Jun" <zhujun2@cmss.chinamobile.com>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH] leds: netxbig: Release the GPIO extension device after parsing
Date: Thu, 12 Nov 2026 07:23:44 +0000 [thread overview]
Message-ID: <sashiko-outbox-210598@kernel.org> (raw)
In-Reply-To: <20261112071657.154479-1-zhujun2@cmss.chinamobile.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] leds: netxbig: wrong Fixes tag for netxbig_leds_get_of_pdata()
leak
--
commit e84470b4e5048a49d0dea30c99c1fa99f03b9fb5
Author: Zhu Jun <zhujun2@cmss.chinamobile.com>
> leds: netxbig: Release the GPIO extension device after parsing
>
> netxbig_leds_get_of_pdata() gets a device reference with
> of_find_device_by_node(). Error paths release it, but successful
> parsing returns without putting the device. The parsed platform data
> does not retain that device pointer.
>
> Route successful parsing through the existing device cleanup label.
>
> Fixes: 2976b1798909 ("leds: netxbig: add device tree binding")
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
[Severity: Low]
Should the Fixes: tag reference 9af512e81964 ("leds: netxbig: Convert to use
GPIO descriptors") instead?
Commit 2976b1798909 ("leds: netxbig: add device tree binding") only parsed
gpio_ext_np and did not call of_find_device_by_node(). That call was
added in 9af512e81964 ("leds: netxbig: Convert to use GPIO descriptors"),
and 311066aa9ebc ("leds: netxbig: add missing put_device() call in
netxbig_leds_get_of_pdata()") later added put_device() on the error paths
while leaving the success path returning early.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261112071657.154479-1-zhujun2@cmss.chinamobile.com?part=1
prev parent reply other threads:[~2026-11-12 7:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 7:16 [PATCH] leds: netxbig: Release the GPIO extension device after parsing Zhu Jun
2026-11-12 7:23 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-210598@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox