[PATCH] leds: netxbig: Release the GPIO extension device after parsing

[PATCH] leds: netxbig: Release the GPIO extension device after parsing

[Zhu Jun]

netxbig_leds_get_of_pdata() gets a device reference with
of_find_device_by_node(). Error paths release it, but successful
parsing returns without putting the device. The parsed platform data
does not retain that device pointer.

Route successful parsing through the existing device cleanup label.

Fixes: 2976b1798909 ("leds: netxbig: add device tree binding")
Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
 drivers/leds/leds-netxbig.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/leds/leds-netxbig.c b/drivers/leds/leds-netxbig.c
index 6f59f91fac6c..7539389e4a29 100644
--- a/drivers/leds/leds-netxbig.c
+++ b/drivers/leds/leds-netxbig.c
@@ -593,8 +593,7 @@ static int netxbig_leds_get_of_pdata(struct device *dev,
 
 	pdata->leds = leds;
 	pdata->num_leds = num_leds;
-
-	return 0;
+	ret = 0;
 
 put_device:
 	put_device(gpio_ext_dev);
-- 
2.51.0

Re: [PATCH] leds: netxbig: Release the GPIO extension device after parsing

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] leds: netxbig: wrong Fixes tag for netxbig_leds_get_of_pdata()
  leak
--

commit e84470b4e5048a49d0dea30c99c1fa99f03b9fb5
Author: Zhu Jun <zhujun2@cmss.chinamobile.com>

> leds: netxbig: Release the GPIO extension device after parsing
>
> netxbig_leds_get_of_pdata() gets a device reference with
> of_find_device_by_node(). Error paths release it, but successful
> parsing returns without putting the device. The parsed platform data
> does not retain that device pointer.
>
> Route successful parsing through the existing device cleanup label.
>
> Fixes: 2976b1798909 ("leds: netxbig: add device tree binding")
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>

[Severity: Low]
Should the Fixes: tag reference 9af512e81964 ("leds: netxbig: Convert to use
GPIO descriptors") instead?

Commit 2976b1798909 ("leds: netxbig: add device tree binding") only parsed
gpio_ext_np and did not call of_find_device_by_node().  That call was
added in 9af512e81964 ("leds: netxbig: Convert to use GPIO descriptors"),
and 311066aa9ebc ("leds: netxbig: add missing put_device() call in
netxbig_leds_get_of_pdata()") later added put_device() on the error paths
while leaving the success path returning early.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112071657.154479-1-zhujun2@cmss.chinamobile.com?part=1