Linux LED subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Alexander Kurz" <akurz@blala.de>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH 1/2] leds: leds-mc13783: use unified device property API
Date: Sat, 21 Nov 2026 07:50:35 +0000	[thread overview]
Message-ID: <sashiko-outbox-226805@kernel.org> (raw)
In-Reply-To: <20261121074239.8745-1-akurz@blala.de>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] leds: mc13783: wrong fsl,led-control property name in
  mc13xxx_led_probe_dt()
--

commit 68fd5224b7b684d27cc41e7ff6cfe1fa69173623
Author: Alexander Kurz <akurz@blala.de>

leds: leds-mc13783: use unified device property API

This commit replaces OF-specific API calls in mc13xxx_led_probe_dt() with
the unified fwnode device property API.

> diff --git a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c
> index 19c1b51475db6..c3bbbc8ef946b 100644
> --- a/drivers/leds/leds-mc13783.c
> +++ b/drivers/leds/leds-mc13783.c

[ ... ]

> @@ -122,34 +122,34 @@ static struct mc13xxx_leds_platform_data __init *mc13xxx_led_probe_dt(
>  	if (!pdata)
>  		return ERR_PTR(-ENOMEM);
>  
> -	struct device_node *parent __free(device_node) =
> -		of_get_child_by_name(dev_of_node(dev->parent), "leds");
> +	struct fwnode_handle *parent __free(fwnode_handle) =
> +		device_get_named_child_node(dev->parent, "leds");
>  	if (!parent)
>  		return ERR_PTR(-ENODATA);
>  
> -	ret = of_property_read_u32_array(parent, "led-control",
> +	ret = fwnode_property_read_u32_array(parent, "fsl,led-control",
>  					 pdata->led_control,
>  					 leds->devtype->num_regs);
>  	if (ret)
>  		return ERR_PTR(ret);

[Severity: High]
Does changing the property name from "led-control" to "fsl,led-control"
break Device Tree probing?  The binding in
Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml and all in-tree
Device Trees define this property as "led-control", so
fwnode_property_read_u32_array() will return -EINVAL and abort
mc13xxx_led_probe_dt().

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261121074239.8745-1-akurz@blala.de?part=1

      parent reply	other threads:[~2026-11-21  7:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21  7:42 [PATCH 1/2] leds: leds-mc13783: use unified device property API Alexander Kurz
2026-11-21  7:42 ` [PATCH 2/2] leds: leds-mc13783: enable driver for deferred probe Alexander Kurz
2026-11-21  7:51   ` sashiko-bot
2026-11-21  7:50 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-226805@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=akurz@blala.de \
    --cc=lee@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox