Linux LED subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Alexander Kurz" <akurz@blala.de>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH 2/2] leds: leds-mc13783: enable driver for deferred probe
Date: Sat, 21 Nov 2026 07:51:01 +0000	[thread overview]
Message-ID: <sashiko-outbox-226806@kernel.org> (raw)
In-Reply-To: <20261121074239.8745-2-akurz@blala.de>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] leds: leds-mc13783: wrong DT property fsl,led-control breaks
  probe
--

commit 192aa62c8f136ce683903471ddceeeabc5b01f1f
Author: Alexander Kurz <akurz@blala.de>

leds: leds-mc13783: enable driver for deferred probe

This commit replaces module_platform_driver_probe() with
module_platform_driver() and drops __init from the probe functions so that
mc13xxx-led can probe after the parent MFD device is registered.

> diff --git a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c
> index c3bbbc8ef946b..042cefde7853c 100644
> --- a/drivers/leds/leds-mc13783.c
> +++ b/drivers/leds/leds-mc13783.c
> @@ -109,7 +109,7 @@ static int mc13xxx_led_set(struct led_classdev *led_cdev,
>  }
>  
>  #ifdef CONFIG_OF
> -static struct mc13xxx_leds_platform_data __init *mc13xxx_led_probe_dt(
> +static struct mc13xxx_leds_platform_data *mc13xxx_led_probe_dt(
>  	struct platform_device *pdev)
>  {
>  	struct mc13xxx_leds *leds = platform_get_drvdata(pdev);

[Severity: High]
Does mc13xxx_led_probe_dt() fail with -EINVAL on all Device Tree boards
now that mc13xxx_led_probe() can run?

The preceding commit "leds: leds-mc13783: use unified device property API"
changed the property lookup in mc13xxx_led_probe_dt() from "led-control"
to "fsl,led-control":

drivers/leds/leds-mc13783.c:mc13xxx_led_probe_dt() {
    ...
	ret = fwnode_property_read_u32_array(parent, "fsl,led-control",
					 pdata->led_control,
					 leds->devtype->num_regs);
	if (ret)
		return ERR_PTR(ret);
    ...
}

However, the binding in
Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml (which sets
additionalProperties: false on the leds node) and all in-tree DTS files
use "led-control" without a vendor prefix, so
fwnode_property_read_u32_array() fails and aborts probe.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261121074239.8745-1-akurz@blala.de?part=2

  reply	other threads:[~2026-11-21  7:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21  7:42 [PATCH 1/2] leds: leds-mc13783: use unified device property API Alexander Kurz
2026-11-21  7:42 ` [PATCH 2/2] leds: leds-mc13783: enable driver for deferred probe Alexander Kurz
2026-11-21  7:51   ` sashiko-bot [this message]
2026-11-21  7:50 ` [PATCH 1/2] leds: leds-mc13783: use unified device property API sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-226806@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=akurz@blala.de \
    --cc=lee@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox